New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add module for validating tracks in miniAOD and fix track-to-PackedCandidate association #9630
Add module for validating tracks in miniAOD and fix track-to-PackedCandidate association #9630
Conversation
As only some PFCandidates have reference to a Track, mappingTk contains -1 elements. Accessing reverseOrder with -1 gives junk that is then inserted to mappingTk. When these elements are accessed from edm::Association, it will throw "index in the map out of upper boundary" exception, while the expected behaviour would be a null edm::Ref. The fix is to access reverseOrder only if mappingTk[i] is non-negative.
A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_7_5_X. Add module for validating tracks in miniAOD and fix track-to-PackedCandidate association It involves the following packages: DQMOffline/Configuration @cmsbuild, @vadler, @danduggan, @deguio, @monttj can you please review it and eventually sign? Thanks. |
please test |
The tests are being triggered in jenkins. |
-1 runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+MINIAODMCUP15/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+MINIAODMCUP15.log ----- Begin Fatal Exception 18-Jun-2015 18:34:27 CEST----------------------- An exception of category 'Configuration' occurred while [0] Constructing the EventProcessor [1] Constructing module: class=MixingModule label='mix' Exception Message: RootEmbeddedFileSequence no input files specified for secondary input source. ----- End Fatal Exception ------------------------------------------------- 50202.0 step2 runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50+MINIAODMCUP1550/step2_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50+MINIAODMCUP1550.log ----- Begin Fatal Exception 18-Jun-2015 18:34:32 CEST----------------------- An exception of category 'Configuration' occurred while [0] Constructing the EventProcessor [1] Constructing module: class=MixingModule label='mix' Exception Message: RootEmbeddedFileSequence no input files specified for secondary input source. ----- End Fatal Exception ------------------------------------------------- you can see the results of the tests here: |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
Add module for validating tracks in miniAOD and fix track-to-PackedCandidate association
This PR adds a DQM module for comparing the tracks embedded in PackedCandidates to the corresponding generalTracks. The comparison is performed by filling a set of histograms from differences of several quantities that are expected to be equal within the numerical accuracy (two exceptions being "diffNdof" and "diffHitPatternNumberOfLostPixelHits", to be documented on some twiki page).
I also decided to include #9564 here since it is a prerequisite and its integration hasn't progressed yet. Without it the code would sooner or later throw an exception with
Tested in CMSSW_7_5_X_2015-06-06-2300 with wf 11325. No other changes expected than new histograms under "Tracking/PackedCandidate" folder.
@rovere @VinInn @arizzi @gpetruc