Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add module for validating tracks in miniAOD and fix track-to-PackedCandidate association #9630

Merged
merged 4 commits into from Jun 29, 2015

Conversation

makortel
Copy link
Contributor

This PR adds a DQM module for comparing the tracks embedded in PackedCandidates to the corresponding generalTracks. The comparison is performed by filling a set of histograms from differences of several quantities that are expected to be equal within the numerical accuracy (two exceptions being "diffNdof" and "diffHitPatternNumberOfLostPixelHits", to be documented on some twiki page).

I also decided to include #9564 here since it is a prerequisite and its integration hasn't progressed yet. Without it the code would sooner or later throw an exception with

Exception Message:
Association: index in the map out of upper boundary

Tested in CMSSW_7_5_X_2015-06-06-2300 with wf 11325. No other changes expected than new histograms under "Tracking/PackedCandidate" folder.

@rovere @VinInn @arizzi @gpetruc

As only some PFCandidates have reference to a Track, mappingTk
contains -1 elements. Accessing reverseOrder with -1 gives junk that
is then inserted to mappingTk. When these elements are accessed from
edm::Association, it will throw "index in the map out of upper
boundary" exception, while the expected behaviour would be a null
edm::Ref.

The fix is to access reverseOrder only if mappingTk[i] is non-negative.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_7_5_X.

Add module for validating tracks in miniAOD and fix track-to-PackedCandidate association

It involves the following packages:

DQMOffline/Configuration
PhysicsTools/PatAlgos
Validation/RecoTrack

@cmsbuild, @vadler, @danduggan, @deguio, @monttj can you please review it and eventually sign? Thanks.
@TaiSakuma, @schoef, @rappoccio, @threus, @mmarionncern, @imarches, @ahinzmann, @acaudron, @jdolen, @ferencek, @cerati, @rociovilar, @GiacomoSguazzoni, @rovere, @VinInn, @nhanvtran, @wmtford, @dgulhan, @appeltel, @gpetruc, @istaslis, @mariadalfonso, @pvmulder this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented Jun 18, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-1
Tested at: 89a0dd1
When I ran the RelVals I found an error in the following worklfows:
25202.0 step2

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+MINIAODMCUP15/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+MINIAODMCUP15.log
----- Begin Fatal Exception 18-Jun-2015 18:34:27 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
Exception Message:
RootEmbeddedFileSequence no input files specified for secondary input source.
----- End Fatal Exception -------------------------------------------------

50202.0 step2

runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50+MINIAODMCUP1550/step2_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50+MINIAODMCUP1550.log
----- Begin Fatal Exception 18-Jun-2015 18:34:32 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
Exception Message:
RootEmbeddedFileSequence no input files specified for secondary input source.
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9630/5555/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants