Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vtx smearing parameters from run 247324 #9645

Conversation

rmanzoni
Copy link
Contributor

Add vtx smearing parameters from run 247324, as needed by dN/dEta analysis

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rmanzoni (Riccardo Manzoni) for CMSSW_7_5_X.

Add vtx smearing parameters from run 247324

It involves the following packages:

IOMC/EventVertexGenerators

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@civanch
Copy link
Contributor

civanch commented Jun 16, 2015

@rmanzoni , it is not enough to add vertex smearing parameters in this file. You need also add corresponding lines into CMSSW/​Configuration/​StandardSequences/​python/​VtxSmeared.py

@cmsbuild
Copy link
Contributor

Pull request #9645 was updated. @cmsbuild, @civanch, @franzoni, @mdhildreth, @davidlange6 can you please check and sign again.

@rmanzoni
Copy link
Contributor Author

@civanch sorry, now the PR should be complete.
However I don't understand why I see this conflict from the web interface
https://github.com/cms-sw/cmssw/pull/9645/files#diff-e1cee80113cf1157608571659e48271dL43
while I think it shouldn't be there, as this is what I see in 75X
https://github.com/cms-sw/cmssw/blob/CMSSW_7_5_X/Configuration/StandardSequences/python/VtxSmeared.py#L43

@civanch
Copy link
Contributor

civanch commented Jun 16, 2015

@rmanzoni , this I do not know, from my point of view current PR is OK.

@civanch
Copy link
Contributor

civanch commented Jun 16, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-1
@rmanzoni This pull request cannot be automatically merged, could you please rebase it?
you can see the log for git cms-merge-topic here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9645/8206/git-merge-result

@civanch
Copy link
Contributor

civanch commented Jun 18, 2015

+1

@davidlange6
Copy link
Contributor

@rmanzoni - could I ask we change the name of this ZeroTeslaDNDEtaCollision2015Vtx to Run247324Vtx so that its self documenting where the numbers came from later.

@civanch
Copy link
Contributor

civanch commented Jun 19, 2015

May be ZeroTeslaRun247324Vtx ?

@rmanzoni
Copy link
Contributor Author

@davidlange6 @civanch either is fine to me, let me just check with the AlCa folks @mmusich @diguida, who proposed the current name in first place

@diguida
Copy link
Contributor

diguida commented Jun 19, 2015

@davidlange6 @civanch @rmanzoni last bet:

ZeroTeslaRun247324CollisionVtxSmearingParameters

In this way we know:

  • It is a collision run
  • We have a run number
  • We know the magnet field.

@davidlange6
Copy link
Contributor

+1
Beam spot and collisions seem redundant but ok for me

davidlange6 added a commit that referenced this pull request Jun 19, 2015
…NdEta_vtx_smearing

Add vtx smearing parameters from run 247324
@davidlange6 davidlange6 merged commit b08ba44 into cms-sw:CMSSW_7_5_X Jun 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants