New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vtx smearing parameters from run 247324 #9645
Add vtx smearing parameters from run 247324 #9645
Conversation
A new Pull Request was created by @rmanzoni (Riccardo Manzoni) for CMSSW_7_5_X. Add vtx smearing parameters from run 247324 It involves the following packages: IOMC/EventVertexGenerators @cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. |
@rmanzoni , it is not enough to add vertex smearing parameters in this file. You need also add corresponding lines into CMSSW/Configuration/StandardSequences/python/VtxSmeared.py |
Pull request #9645 was updated. @cmsbuild, @civanch, @franzoni, @mdhildreth, @davidlange6 can you please check and sign again. |
@civanch sorry, now the PR should be complete. |
@rmanzoni , this I do not know, from my point of view current PR is OK. |
please test |
The tests are being triggered in jenkins. |
-1 |
+1 |
@rmanzoni - could I ask we change the name of this ZeroTeslaDNDEtaCollision2015Vtx to Run247324Vtx so that its self documenting where the numbers came from later. |
May be ZeroTeslaRun247324Vtx ? |
@davidlange6 @civanch either is fine to me, let me just check with the AlCa folks @mmusich @diguida, who proposed the current name in first place |
@davidlange6 @civanch @rmanzoni last bet:
In this way we know:
|
+1 |
…NdEta_vtx_smearing Add vtx smearing parameters from run 247324
Add vtx smearing parameters from run 247324, as needed by dN/dEta analysis