Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set hierarchy constraints as default in Millepede #9713

Conversation

mschrode
Copy link

This sets back the default way constraints are treated in Millepede to using hierarchy constraints, and reverts the temporary changes introduced with #6254. Previous problems were found to be due to numerical effects in pede. These are solved in >=rev137, which uses 'elimination' instead of lagrangian multipliers.

Previous problems were found to be due to numerical effects in
pede. These are solved in >=rev137, which uses 'elimination'
instead of lagrangian multipliers.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mschrode (Matthias Schroeder) for CMSSW_7_5_X.

Set hierarchy constraints as default in Millepede

It involves the following packages:

Alignment/CommonAlignmentAlgorithm

@cmsbuild, @mmusich, @diguida, @cerminar can you please review it and eventually sign? Thanks.
@ghellwig, @pakhotin, @frmeier, @mmusich, @tlampen this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mmusich
Copy link
Contributor

mmusich commented Jun 22, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

@diguida - is there a PR for the mede cmsdist request yet?

@diguida
Copy link
Contributor

diguida commented Jun 24, 2015

@davidlange6 not yet, requested to TkAl group.

@davidlange6
Copy link
Contributor

@diguida - is there a PR for the mede cmsdist request yet?

@diguida
Copy link
Contributor

diguida commented Jul 2, 2015

@diguida
Copy link
Contributor

diguida commented Jul 2, 2015

@davidlange6 here they are:
cms-sw/cmsdist#1648 for 76X
cms-sw/cmsdist#1649 for 75X

@mmusich
Copy link
Contributor

mmusich commented Jan 26, 2016

-1 not for this release cylce anymore

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @mmusich
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@mmusich
Copy link
Contributor

mmusich commented Jan 26, 2016

unhold

@cmsbuild cmsbuild removed the hold label Jan 26, 2016
@mmusich
Copy link
Contributor

mmusich commented Jan 26, 2016

-1
not for this release cycle

@ghellwig
Copy link

@mmusich has this been forward-ported to 80X?

@mmusich
Copy link
Contributor

mmusich commented Jan 26, 2016

@ghellwig yes. 4eef681

@ghellwig
Copy link

@mmusich Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants