Make the dyld-based library search behavior default for non-modules. #165

smuzaffar · 2022-03-22T08:46:01Z

The dyld-based system was developed in the context on C++ modules but it turned
into a modules-agnostic feature. Instead of having to maintain more code, we
should rely on it even for non-modules build of ROOT.

The dyld-based system was developed in the context on C++ modules but it turned into a modules-agnostic feature. Instead of having to maintain more code, we should rely on it even for non-modules build of ROOT.

smuzaffar · 2022-03-22T08:46:18Z

test parameters:

full_cmssw = true

cmsbuild · 2022-03-22T08:46:23Z

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch cms/master/569be7e.

@cmsbuild, @smuzaffar, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

smuzaffar · 2022-03-22T08:46:26Z

please test

cmsbuild · 2022-03-22T15:51:55Z

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7812dd/23267/summary.html
COMMIT: 123a985
CMSSW: CMSSW_12_4_X_2022-03-21-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/root/165/23267/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:


-- Configuring incomplete, errors occurred!
See also "/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc10/lcg/root/6.24.07-abaf3750886fcc26df9078c0901cc860/build/CMakeFiles/CMakeOutput.log".
See also "/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc10/lcg/root/6.24.07-abaf3750886fcc26df9078c0901cc860/build/CMakeFiles/CMakeError.log".
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.A8HN23 (%build)


RPM build errors:
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.A8HN23 (%build)

smuzaffar · 2022-03-22T16:45:51Z

please test for CMSSW_12_4_ROOT6_X

smuzaffar · 2022-03-22T16:47:27Z

oops sorry @vgvassilev , test were run against a wrong cmssw release. I have restarted using correct release

cmsbuild · 2022-03-22T16:57:31Z

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7812dd/23267/summary.html
COMMIT: 123a985
CMSSW: CMSSW_12_4_X_2022-03-21-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/root/165/23267/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:


-- Configuring incomplete, errors occurred!
See also "/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc10/lcg/root/6.24.07-abaf3750886fcc26df9078c0901cc860/build/CMakeFiles/CMakeOutput.log".
See also "/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc10/lcg/root/6.24.07-abaf3750886fcc26df9078c0901cc860/build/CMakeFiles/CMakeError.log".
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.A8HN23 (%build)


RPM build errors:
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.A8HN23 (%build)

cmsbuild · 2022-03-23T06:47:51Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7812dd/23290/summary.html
COMMIT: 123a985
CMSSW: CMSSW_12_4_ROOT6_X_2022-03-21-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/root/165/23290/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7812dd/23290/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7812dd/23290/git-merge-result

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-7812dd/39434.911_TTbar_14TeV+2026D88_DD4hep+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

No significant changes to the logs found
Reco comparison results: 16386 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3695650
DQMHistoTests: Total failures: 92722
DQMHistoTests: Total nulls: 61
DQMHistoTests: Total successes: 3602845
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 2.245 KiB( 48 files compared)
DQMHistoSizes: changed ( 11834.0 ): 2.249 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 204 log files, 45 edm output root files, 49 DQM output files
TriggerResults: found differences in 7 / 48 workflows

cmsbuild · 2022-03-23T06:47:53Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7812dd/23290/summary.html
COMMIT: 123a985
CMSSW: CMSSW_12_4_ROOT6_X_2022-03-21-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/root/165/23290/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7812dd/23290/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7812dd/23290/git-merge-result

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-7812dd/39434.911_TTbar_14TeV+2026D88_DD4hep+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

No significant changes to the logs found
Reco comparison results: 16386 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3695650
DQMHistoTests: Total failures: 92722
DQMHistoTests: Total nulls: 61
DQMHistoTests: Total successes: 3602845
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 2.245 KiB( 48 files compared)
DQMHistoSizes: changed ( 11834.0 ): 2.249 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 204 log files, 45 edm output root files, 49 DQM output files
TriggerResults: found differences in 7 / 48 workflows

smuzaffar · 2022-03-23T08:18:24Z

please test for CMSSW_12_4_ROOT6_X

Make the dyld-based library search behavior default for non-modules.

123a985

The dyld-based system was developed in the context on C++ modules but it turned into a modules-agnostic feature. Instead of having to maintain more code, we should rely on it even for non-modules build of ROOT.

cmsbuild added externals-pending orp-pending pending-signatures tests-pending labels Mar 22, 2022

cmsbuild added tests-started and removed tests-pending labels Mar 22, 2022

smuzaffar mentioned this pull request Mar 22, 2022

Make the dyld-based library search behavior default for non-modules. root-project/root#10193

Merged

cmsbuild added tests-rejected tests-started and removed tests-started tests-rejected labels Mar 22, 2022

cmsbuild added tests-approved and removed tests-started labels Mar 23, 2022

cmsbuild added tests-started and removed tests-approved labels Mar 23, 2022

smuzaffar closed this Mar 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make the dyld-based library search behavior default for non-modules. #165

Make the dyld-based library search behavior default for non-modules. #165

smuzaffar commented Mar 22, 2022

smuzaffar commented Mar 22, 2022

cmsbuild commented Mar 22, 2022

smuzaffar commented Mar 22, 2022

cmsbuild commented Mar 22, 2022

smuzaffar commented Mar 22, 2022

smuzaffar commented Mar 22, 2022

cmsbuild commented Mar 22, 2022

cmsbuild commented Mar 23, 2022

cmsbuild commented Mar 23, 2022

smuzaffar commented Mar 23, 2022

Make the dyld-based library search behavior default for non-modules. #165

Make the dyld-based library search behavior default for non-modules. #165

Conversation

smuzaffar commented Mar 22, 2022

smuzaffar commented Mar 22, 2022

cmsbuild commented Mar 22, 2022

smuzaffar commented Mar 22, 2022

cmsbuild commented Mar 22, 2022

External Build

smuzaffar commented Mar 22, 2022

smuzaffar commented Mar 22, 2022

cmsbuild commented Mar 22, 2022

External Build

cmsbuild commented Mar 23, 2022

Comparison Summary

cmsbuild commented Mar 23, 2022

Comparison Summary

smuzaffar commented Mar 23, 2022