#5584: Respect bucket index when adjusting geometry indices

codereader · Dec 4, 2021 · 3e50d82 · 3e50d82
1 parent e96f65c
commit 3e50d82
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/radiantcore/rendersystem/backend/GeometryRenderer.h b/radiantcore/rendersystem/backend/GeometryRenderer.h
@@ -180,11 +180,16 @@ class GeometryRenderer :
 
         bucket.removeSurface(slotInfo.firstVertex, slotInfo.numVertices, slotInfo.firstIndex, slotInfo.numIndices);
 
-        // Adjust all offsets in other slots
+        // Adjust all offsets in other slots pointing to the same bucket
         for (auto& slot : _slots)
         {
-            if (slot.firstVertex > slotInfo.firstVertex)
+            if (slot.bucketIndex == slotInfo.bucketIndex && 
+                slot.firstVertex > slotInfo.firstVertex && 
+                slot.firstVertex != InvalidVertexIndex)
             {
+                assert(slot.firstVertex >= slotInfo.numVertices);
+                assert(slot.firstIndex >= slotInfo.numIndices);
+
                 slot.firstVertex -= slotInfo.numVertices;
                 slot.firstIndex -= slotInfo.numIndices;
             }