Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add web config for max duration of check container life cycle #3030

Closed
wants to merge 1 commit into from
Closed

Add web config for max duration of check container life cycle #3030

wants to merge 1 commit into from

Conversation

khng
Copy link
Contributor

@khng khng commented Jan 11, 2019

Add functionality for issue #2988.

@khng khng force-pushed the configure-rebalancing-duration branch from 4b5d3c1 to 03708b7 Compare January 11, 2019 14:52
vito
vito requested changes Jan 11, 2019
View reviewed changes
Copy link
Member

@vito vito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this'll be super useful! Probably better to dependency-inject the config instead at this point though - left a comment to that effect.

atc/atccmd/command.go Outdated Show resolved Hide resolved
@khng khng force-pushed the configure-rebalancing-duration branch from 03708b7 to c82f9ec Compare January 11, 2019 19:56
@khng
Copy link
Contributor Author

khng commented Jan 11, 2019

Seemed off to keep the global ContainerExpiries variable and adding a side effect to NewScannerFactory to update it so I opted to pass the ContainerOwnerExpiries down to the Scanner. Is this what you had in mind?

@khng khng force-pushed the configure-rebalancing-duration branch 3 times, most recently from 617b15b to a754953 Compare January 11, 2019 21:06
Add web configuration to specify max duration for check resource cont…
d2f19b9 
…ainer life cycle

Signed-off-by: Ka Hin Ng <kang@pivotal.io>
@khng khng force-pushed the configure-rebalancing-duration branch from a754953 to d2f19b9 Compare January 11, 2019 22:34
@vito
Copy link
Member

vito commented Feb 6, 2019

Hey, I think we're actually gonna do #3079 soon (which removes check container re-use entirely) so I think we can close this. Thanks though!

@vito vito closed this Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vito vito vito requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@khng @vito