fix: remove public Query field from go generated types #6849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vito
approved these changes
Mar 7, 2024
Don't worry it's our good ole friend #6770 😱 |
This could cause name clashes and was annoying. Thankfully, there's only one legitimate need for this field to be public - interfaces. We can provide a workaround for this with the new `WithGraphQLQuery` method on generated types, which resets the underlying type, and sets the query. Signed-off-by: Justin Chadwell <me@jedevc.com>
Signed-off-by: Justin Chadwell <me@jedevc.com>
jedevc
force-pushed
the
go-hide-query-field
branch
from
c038de3
to
c291d13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #6716 - people were using
Queryas a method name, see discord.This could cause name clashes and was annoying. Thankfully, there's only one legitimate need for this field to be public - interfaces.
We can provide a workaround for this with the new
WithGraphQLQuerymethod on generated types, which resets the underlying type, and sets the query.I did briefly consider the idea of using an
XXXprefix forQuery, but I prefer having a method to set the private field since then it's not possible to set the query, but not modify the cached properties, which would definitely result in weird things happening.