fix: propagate graphql client to child clients #6851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This regressed in 62ced56, and meant that child clients were invalid, and couldn't be called with `Do()`, as well as causing `GraphQLClient()` to return an invalid nil value. This only previously worked because the GraphQL client and the dagger client shared the same name `client`. When this property was removed, the propagation stopped working. Now, we make this special case explicit. Signed-off-by: Justin Chadwell <me@jedevc.com>
|
https://github.com/octohelm/wagon/blob/main/pkg/engine/daggerutil/querybuilder.go#L9 panic in dagger.Client.Do(), .client is nil I found only happen on the Client returned by Pipeline(). |
vito
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #6850 (cc @morlay)
This regressed in #6716, and meant that child clients were invalid, and couldn't be called with
Do(), as well as causingGraphQLClient()to return an invalid nil value.This only previously worked because the GraphQL client and the dagger client shared the same name
client. When this property was removed, the propagation stopped working. Now, we make this special case explicit.@morlay if you have a more specific stack trace from the panic, or can somehow confirm that this fixes your issue that would be super helpful.