use pre-upgrade hook to set resource policy on CRD #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsanda
requested review from
bradfordcp,
jimdickinson,
johntrimble,
respringer and
sandoichi
as code owners
|
@jsanda @jimdickinson any news on that issue ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #324
In #304 customresourcedefinition.yaml was moved back to the templates directory because on
helm upgradeHelm would delete the CRD since it no longer exists in the templates directory. This has come up a number of times in the Helm community. See helm/helm#8163 for background.In this PR I move customresourcedefinition.yaml back to the crds directory. I use a pre-upgrade hook to add an annotation to the CRD that tells Helm to preserve the CRD even though it has been moved. I tested this manually. I also ran
M_INTEG_DIR=upgrade_operator mage integ:runto make sure the upgrade works.