GEM online DQM updates #1028
GEM online DQM updates #1028
Conversation
|
Don't you need to have any PR in |
|
Could you please reply to the above comment. Thanks |
|
I did not hear back from you regarding this PR. Do you want to include it in next month release or not? please comment. Thanks |
|
Sorry for my super late response... Best regards, [1] https://indico.cern.ch/event/1005033/#12-simplification-of-online-dq |
|
I am including this PR then. I dont' attend GEM DQM general meetings. Any specific request for deployment in cmsweb should be made accordingly. |
|
Ahh, yep I should do so... Many thanks! Best regards, |
|
I have deployed this PR in http://cmsweb-testbed.cern.ch cluster. Please test and provide validation results at this ticket https://gitlab.cern.ch/cms-http-group/doc/-/issues/253 |
|
Have you tested this PR in the testbed ? |
|
Despite sending you messages about validation results, I did not get any reply from you regarding this PR. As Tuesday 2nd March is production upgrade, I'll remove this PR from deployment in the production nodes if I don't hear anything from you regarding validation results by Monday morning. |
This reverts commit 0aca53b.
|
I have already created revert PR for this which will remove these changes after merging it. |
|
Sorry for my forget of reply... But also I had no idea how to do when I got your reply after the merge. I found that there is nothing I can do but just watch all the GEM onlineDQM GUI are working as desired. How can I test it in the testbed? I tried to find an instruction for that but I cannot. Or, just reporting everything is fine/something is weird is all of what I should do? (But yep, then I should ask these questions much earlier...) Best regards, |
|
You can test it on the testbed cluster https://cmsweb-testbed.cern.ch. This is relevant URL https://cmsweb-testbed.cern.ch/dqm/dev/ |
|
You mean upload any GEM DQM root file into https://cmsweb-testbed.cern.ch/dqm/dev/ (by visDQMUpload) and check if the GUI shows everything well? Best regards, |
|
And also I checked all of Online, Online-playback, Online-test in https://cmsweb-testbed.cern.ch/ and GEM GUI is working well, as I mentioned. |
|
Well, yes this is offlineDQM. I don't know how it can be testbed. Currently, this PR is deployed in this node only. |
|
Then... what should I do? I mean, where should I upload my DQM plots and check if it is okay or not? |
|
I don't know how to test it. CMSWEB only provides the infrastructure to deploy and run services. How to test services is the developer's responsibility. You may ask DQM folks about this. |
|
Okay, then what should I show for the validation? Actually I saw that all GEM onlineDQM plots from MWGR No. 1 in 2021 are displayed in the P5 onlineDQM during the run and the desired plots are also found in all onlineDQM sites (Online, Online-playback, Online-test) in https://cmsweb-testbed.cern.ch/, and then I thought it was enough. But it seems like I have to show something more. |
|
You don't need to show me anything. Just confirm that this PR is ready to deploy in the production nodes. Then, I'll deploy it. |
|
Byeonghak, on cmsweb all service responsible should properly test their services before putting changes to production. How to test the service is up to dev team which responsible for it. It can be a simple test to query API, or more comprehensive suit of tests including remote/local API access, testing web interfaces. Everything is up to dev team to define. For CMSWEB operator, we should only say if it is ok or not to include new code to production release. You represent now DQM dev team and you should define your own set of tests and based on them just say if your new release is ok or not. |
|
Hi @vkuznet, Well, I already tested in a local and private site and checked everything was okay, and also (sorry to mention it too frequently) saw the new version displays all plots well in sites (both central and testbed) in CMSWEB. I thought it would be enough to say that it is confirmed, but now I think I need to ask to DQM folks what I should do more in this stage to make sure everything, like how to test the query to the testbed by myself. I'll ask and check more ASAP. Sorry for this mess up. Best regards, |
|
I found that I already have confirmations in the level of DQM dev team. The updates are presented in [1] and DQM dev team already tested and confirmed the updates. If you want, I can forward the mail about that. I asked again to DQM dev team and have got that it is enough for the confirmation. Sorry for this late. Best regards, |
|
Hi @quark2 |
|
Thanks a lot! I should ask and make sure about that earlier... Best regards, |
PR description:
This PR updates and extends the part of onlineDQM for GEM. The details are following:
This PR is related to PRs on cms-sw; see
cms-sw/cmssw#32792 (to master)
cms-sw/cmssw#32791 (backport)
For more detail, please see this to check more details
@jshlee @watson-ij