Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show the proper message with madis2nc and ACARS input (not ACARS profiler) #1409

Closed
4 of 19 tasks
hsoh-u opened this issue Jul 10, 2020 · 2 comments · Fixed by #1483
Closed
4 of 19 tasks

Show the proper message with madis2nc and ACARS input (not ACARS profiler) #1409

hsoh-u opened this issue Jul 10, 2020 · 2 comments · Fixed by #1483
Assignees
@hsoh-u
Labels
priority: medium Medium Priority type: bug Fix something that is not working
Projects
METplus Version 3.1 Support
Milestone
MET 9.1.1 (bugfix)

Comments

@hsoh-u
Copy link
Collaborator

hsoh-u commented Jul 10, 2020

Describe the Problem

madis2nc supports ACARS profiler and the other ACARS data is not supported (segfault). It's noce to give the proper error message instead of segmentation fault.

Expected Behavior

Show error message instead of seg. fault

Environment

Describe your runtime environment:

  1. Machine: Linux Workstation
  2. OS: RedHat Linux
  3. Software version number(s)

To Reproduce

Describe the steps to reproduce the behavior:

  1. madis2nc acars.2020010_1700 test.nc -type acarsProfiles

note: acars.2020010_1700 is not ACARS profiler. The following variables are missing: profileAirport, profileTime, trackLat, trackLon, altitude, obsTimeOfDay.

Relevant Deadlines

NONE.

Funding Source

NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required (Howard)
  • Select scientist(s) or no scientist required (None)

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Review projects and select relevant Repository and Organization ones
  • Select milestone

Define Related Issue(s)

Consider the impact to the other METplus components.

Bugfix Checklist

See the METplus Workflow for details.

  • Complete the issue definition above.
  • Fork this repository or create a branch of master_<Version>.
    Branch name: bugfix_<Issue Number>_master_<Version>_<Description>
  • Fix the bug and test your changes.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into master_<Version>.
    Pull request: bugfix <Issue Number> master_<Version> <Description>
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Complete the steps above to fix the bug on the develop branch.
    Branch name: bugfix_<Issue Number>_develop_<Description>
    Pull request: bugfix <Issue Number> develop <Description>
  • Close this issue.
@hsoh-u hsoh-u added type: bug Fix something that is not working component: application code priority: medium Medium Priority labels Jul 10, 2020
@hsoh-u hsoh-u added this to the MET 10.0 milestone Jul 10, 2020
@hsoh-u hsoh-u self-assigned this Jul 10, 2020
@JohnHalleyGotway JohnHalleyGotway added this to To do in METplus Version 3.1 Support via automation Aug 27, 2020
@JohnHalleyGotway
Copy link
Collaborator

Since this is an apparent bug in met-9.1, I'm reassigning this to:
Project = METplus Version 3.1 Support
Milestone = MET 9.1.1 (bugfix)

hsoh-u added a commit that referenced this issue Sep 8, 2020
@hsoh-u
#1409 Check if there are missing variables and give the proper log me…
4c89879 
…ssage
hsoh-u added a commit that referenced this issue Sep 8, 2020
@hsoh-u
#1409 Check if there are missing variables and give the proper log me…
531bebf 
…ssage
@hsoh-u hsoh-u moved this from To do to In progress in METplus Version 3.1 Support Sep 9, 2020
@JohnHalleyGotway JohnHalleyGotway linked a pull request Sep 9, 2020 that will close this issue
Bugfix 1409 develop non_madis_profiler #1483
Merged
hsoh-u added a commit that referenced this issue Sep 10, 2020
@hsoh-u
#1409 Check if there are missing variables and give the proper log me…
6be676a 
…ssage
JohnHalleyGotway pushed a commit that referenced this issue Sep 10, 2020
@hsoh-u
Bugfix 1409 non madis profiler (#1483)
950e0d9 
* #1409 Check if there are missing variables and give the proper log message

* #1409 Check if there are missing variables and give the proper log message
JohnHalleyGotway pushed a commit that referenced this issue Sep 10, 2020
@hsoh-u
#1409 Check if there are missing variables and give the proper log me…
749c738 
…ssage (#1488)
hsoh-u added a commit that referenced this issue Sep 11, 2020
@hsoh-u
#1409 Make the Qty variables optional
148506b
hsoh-u added a commit that referenced this issue Sep 11, 2020
@hsoh-u
#1409 Make the Qty variables optional
25cf0a0
JohnHalleyGotway pushed a commit that referenced this issue Sep 11, 2020
@hsoh-u
#1409 Make the Qty variables optional (#1490)
7bed535
hsoh-u added a commit that referenced this issue Sep 11, 2020
@hsoh-u
#1409 Make the Qty variables optional
4dfa63c
hsoh-u added a commit that referenced this issue Sep 11, 2020
@hsoh-u
#1409 Make the Qty variables optional
df52c22
JohnHalleyGotway pushed a commit that referenced this issue Sep 11, 2020
@hsoh-u
#1409 Make the Qty variables optional (#1491)
818bb1b
@hsoh-u
Copy link
Collaborator Author

hsoh-u commented Sep 11, 2020

The quality flag variables were excluded from the required variables (reset to NA if the quality flag variables are missing)

@hsoh-u hsoh-u closed this as completed Sep 15, 2020
METplus Version 3.1 Support automation moved this from In progress to Done Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hsoh-u hsoh-u

Labels
priority: medium Medium Priority type: bug Fix something that is not working
Projects
No open projects
METplus Version 3.1 Support
  
Done
Milestone
MET 9.1.1 (bugfix)
Development

Successfully merging a pull request may close this issue.

Bugfix 1409 develop non_madis_profiler dtcenter/MET
2 participants
@hsoh-u @JohnHalleyGotway