Bugfix 1409 develop non_madis_profiler #1483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnHalleyGotway
added this to In progress
in MET-10.0.0-beta1 (10/22/20)
via automation
19 tasks
|
Howard, I'm ready to test this out but can't find the file "acars.2020010_1700" for testing. Can you please tell me where I can find it? |
|
It's at dakota which is not up yet. |
JohnHalleyGotway
approved these changes
Sep 10, 2020
There was a problem hiding this comment.
I tested this and confirmed that the change works as expected. I approve this PR.
With met-9.1 we get a segfault:
MET-master_v9.1/met/bin/madis2nc
musial6:met johnhg$ madis2nc acars.20200108_1700 acars.20200108_1700.nc
DEBUG 1: Reading MADIS File: acars.20200108_1700
DEBUG 2: Processing ACARS Profiles recs = -372500542
Segmentation fault: 11
And with this bugfix branch merged into master_v9.1, we get a more useful error message:
madis2nc acars.20200108_1700 acars.20200108_1700.nc
DEBUG 1: Reading MADIS File: acars.20200108_1700
ERROR :
ERROR : process_madis_acarsProfiles() -> Please check if the input is a ACARS Profiles.
ERROR :
WARNING: missing variable: profileAirport
WARNING: missing variable: profileTime
WARNING: missing variable: trackLat
WARNING: missing variable: trackLon
WARNING: missing variable: obsTimeOfDay
WARNING: missing variable: nLevelsDD
WARNING: missing variable: nLevels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It checks the existence of variables and displays the missing variable. If there are any missing variables, it stops. This prevent from the segfault (on reading non-exist variable.
The other branch to the masterV9.1 "bugfix_1409_master_non_madis_profiler" is not pushed yet.