fix: app.keys getter must have a setter either (#3891)

eggjs · Aug 21, 2019 · a9d0cf5 · a9d0cf5
1 parent f170741
commit a9d0cf5
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/lib/application.js b/lib/application.js
@@ -271,6 +271,10 @@ class Application extends EggApplication {
     return this[KEYS];
   }
 
+  set keys(_) {
+    // ignore
+  }
+
   /**
    * reference to {@link Helper}
    * @member {Helper} Application#Helper

diff --git a/test/app/extend/application.test.js b/test/app/extend/application.test.js
@@ -209,4 +209,20 @@ describe('test/app/extend/application.test.js', () => {
       assert(ctx.body === 'middleware resolution');
     });
   });
+
+  describe('app.keys', () => {
+    let app;
+    before(() => {
+      app = utils.app('apps/demo');
+      return app.ready();
+    });
+    after(() => app.close());
+
+    it('should work for app.keys and app.keys=', async () => {
+      assert.deepEqual(app.keys, [ 'foo' ]);
+      // `app.keys=` will be ignored
+      app.keys = undefined;
+      assert.deepEqual(app.keys, [ 'foo' ]);
+    });
+  });
 });