fix: app.keys getter must have a setter either #3891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dead-horse
commented
Aug 19, 2019
| @@ -271,6 +271,10 @@ class Application extends EggApplication { | |||
| return this[KEYS]; | |||
| } | |||
|
|
|||
| set keys(_) { | |||
There was a problem hiding this comment.
get/set 最好还是成对出现，特别是覆盖属性的时候，避免重构踩坑。
There was a problem hiding this comment.
koa 也改进了一下
Codecov Report
@@ Coverage Diff @@
## master #3891 +/- ##
======================================
Coverage 100% 100%
======================================
Files 34 34
Lines 945 945
======================================
Hits 945 945
Continue to review full report at Codecov.
|
dead-horse
referenced
this pull request
in koajs/koa
Aug 19, 2019
|
|
|
koa 不是回滚了么 |
atian25
approved these changes
Aug 21, 2019
koa 是绕过了，但是其实本不应该 koa 关心这个事情的，是 egg 的实现有问题。 |
popomore
pushed a commit
that referenced
this pull request
Aug 21, 2019
fix: app.keys getter must have a setter either (#3891)
|
@dead-horse 这个发版本了么？ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change