-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: app.keys getter must have a setter either #3891
Conversation
@@ -271,6 +271,10 @@ class Application extends EggApplication { | |||
return this[KEYS]; | |||
} | |||
|
|||
set keys(_) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
get/set 最好还是成对出现,特别是覆盖属性的时候,避免重构踩坑。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
koa 也改进了一下
Codecov Report
@@ Coverage Diff @@
## master #3891 +/- ##
======================================
Coverage 100% 100%
======================================
Files 34 34
Lines 945 945
======================================
Hits 945 945
Continue to review full report at Codecov.
|
|
koa 不是回滚了么 |
koa 是绕过了,但是其实本不应该 koa 关心这个事情的,是 egg 的实现有问题。 |
fix: app.keys getter must have a setter either (#3891)
@dead-horse 这个发版本了么? |
Checklist
npm test
passesAffected core subsystem(s)
Description of change