Skip to content

Commit

Permalink
Make RestSearchAction#parseSearchXXX(RestRequest) public
Browse files Browse the repository at this point in the history
When building a plugin with a new search endpoint, you need to parse the request as a searchRequest.

Methods exist in RestSearchAction class but are private.

We will modify them to be public static. This applies to:

* `RestSearchAction#parseSearchRequest(RestRequest)`
* `RestSearchAction#parseSearchSource(RestRequest)`

 Closes #3499.
  • Loading branch information
dadoonet committed Aug 13, 2013
1 parent 4e9bffa commit 248042d
Showing 1 changed file with 3 additions and 3 deletions.
Expand Up @@ -67,7 +67,7 @@ public RestSearchAction(Settings settings, Client client, RestController control
public void handleRequest(final RestRequest request, final RestChannel channel) {
SearchRequest searchRequest;
try {
searchRequest = parseSearchRequest(request);
searchRequest = RestSearchAction.parseSearchRequest(request);
searchRequest.listenerThreaded(false);
SearchOperationThreading operationThreading = SearchOperationThreading.fromString(request.param("operation_threading"), null);
if (operationThreading != null) {
Expand Down Expand Up @@ -117,7 +117,7 @@ public void onFailure(Throwable e) {
});
}

private SearchRequest parseSearchRequest(RestRequest request) {
public static SearchRequest parseSearchRequest(RestRequest request) {
String[] indices = RestActions.splitIndices(request.param("index"));
SearchRequest searchRequest = new SearchRequest(indices);
// get the content, and put it in the body
Expand Down Expand Up @@ -149,7 +149,7 @@ private SearchRequest parseSearchRequest(RestRequest request) {
return searchRequest;
}

private SearchSourceBuilder parseSearchSource(RestRequest request) {
public static SearchSourceBuilder parseSearchSource(RestRequest request) {
SearchSourceBuilder searchSourceBuilder = null;
String queryString = request.param("q");
if (queryString != null) {
Expand Down

0 comments on commit 248042d

Please sign in to comment.