Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unbox Tuple at call sites. #10787

Closed
rmuir opened this issue Apr 24, 2015 · 1 comment
Closed

Unbox Tuple at call sites. #10787

rmuir opened this issue Apr 24, 2015 · 1 comment
Assignees
@jasontedor
Labels
>enhancement

Comments

@rmuir
Copy link
Contributor

rmuir commented Apr 24, 2015

See #10784 for an example doing this for Bootstrap class. IMO this is an easy win for readability of the code and it would be good to do it everywhere.

Unboxing these immediately gives the developer back control of the variable and parameter names. Even when the name is simple like 'settings' it is better than 'v1' or 'v2'. It tells something, as opposed to 'newSettings' or 'oldSettings'. 'v1' and 'v2' are never good names.
@s1monw
Copy link
Contributor

s1monw commented Apr 24, 2015

++

@jasontedor jasontedor removed the help wanted adoptme label Aug 27, 2015
@jasontedor jasontedor self-assigned this Aug 27, 2015
@jasontedor jasontedor removed the v2.1.0 label Aug 27, 2015
@jasontedor jasontedor mentioned this issue Aug 27, 2015
Merged
jasontedor added a commit that referenced this issue Aug 27, 2015
@jasontedor
Remove usage of tuple as a method parameter
fa47399 
This commit backports the fix #13135 for #10787 to 2.0 from master.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasontedor jasontedor

Labels
>enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@clintongormley @rmuir @s1monw @jasontedor