Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ElasticsearchIllegalArgumentException and ElasticsearchIllegalStateException in favor of the JDK one #10794

Closed
s1monw opened this issue Apr 24, 2015 · 4 comments · Fixed by #10862
Closed

Remove ElasticsearchIllegalArgumentException and ElasticsearchIllegalStateException in favor of the JDK one #10794

s1monw opened this issue Apr 24, 2015 · 4 comments · Fixed by #10862
Assignees
@s1monw
Labels
:Core/Infra/Core Core issues without another label >enhancement v2.0.0-beta1

Comments

@s1monw
Copy link
Contributor

s1monw commented Apr 24, 2015

These exceptions are obsolete and our REST layer handles the response code just fine now.
@s1monw s1monw self-assigned this Apr 24, 2015
@dakrone
Copy link
Member

dakrone commented Apr 24, 2015

@s1monw can we remove Preconditions.checkNotNull in favor of the JDK Objects.requireNonNull also?

@s1monw
Copy link
Contributor Author

s1monw commented Apr 24, 2015

IMO we can

@dadoonet
Copy link
Member

Could we have any issue with the transport layer if we change the JDK version and if JDK does not serialize the same way those exceptions?

@s1monw
Copy link
Contributor Author

s1monw commented Apr 28, 2015

Could we have any issue with the transport layer if we change the JDK version and if JDK does not serialize the same way those exceptions?

@dadoonet that makes no difference we also use the same serialization no matter if the exception is in our code or not.

s1monw added a commit to s1monw/elasticsearch that referenced this issue Apr 28, 2015
@s1monw
Remove ElasticsearchIAE and ElasticsearchISE
14fe084 
This commit removes ElasticsearchIAE and ElasticsearchISE in favor of
the JDKs IAE and ISE.

Closes elastic#10794
@s1monw s1monw mentioned this issue Apr 28, 2015
Merged
s1monw added a commit to s1monw/elasticsearch that referenced this issue Apr 29, 2015
@s1monw
Remove ElasticsearchIAE and ElasticsearchISE
05fc0c9 
This commit removes ElasticsearchIAE and ElasticsearchISE in favor of
the JDKs IAE and ISE.

Closes elastic#10794
s1monw added a commit to s1monw/elasticsearch that referenced this issue Apr 29, 2015
@s1monw
Remove ElasticsearchIAE and ElasticsearchISE
94cc785 
This commit removes ElasticsearchIAE and ElasticsearchISE in favor of
the JDKs IAE and ISE.

Closes elastic#10794
s1monw added a commit to s1monw/elasticsearch that referenced this issue Apr 29, 2015
@s1monw
Remove ElasticsearchIAE and ElasticsearchISE
4f14af2 
This commit removes ElasticsearchIAE and ElasticsearchISE in favor of
the JDKs IAE and ISE.

Closes elastic#10794
@dadoonet dadoonet mentioned this issue Apr 29, 2015
Closed
dadoonet added a commit to elastic/elasticsearch-cloud-aws that referenced this issue Apr 29, 2015
@dadoonet
Remove ElasticsearchIllegalArgumentException and `ElasticsearchIlle…
899e84c 
…galStateException` in favor of the JDK one

Related to elastic/elasticsearch#10794

Closes #204.
@dadoonet dadoonet mentioned this issue Apr 29, 2015
Closed
dadoonet added a commit to elastic/elasticsearch-cloud-azure that referenced this issue Apr 29, 2015
@dadoonet
Remove ElasticsearchIllegalArgumentException and `ElasticsearchIlle…
a34a443 
…galStateException` in favor of the JDK one

Related to elastic/elasticsearch#10794

Closes #82.
@dadoonet dadoonet mentioned this issue Apr 29, 2015
Closed
dadoonet added a commit to elastic/elasticsearch-cloud-gce that referenced this issue Apr 29, 2015
@dadoonet
Remove ElasticsearchIllegalArgumentException and `ElasticsearchIlle…
bee93a5 
…galStateException` in favor of the JDK one

Related to elastic/elasticsearch#10794

Closes #51.
dadoonet added a commit to elastic/elasticsearch-analysis-phonetic that referenced this issue Apr 29, 2015
@dadoonet
Remove ElasticsearchIllegalArgumentException and `ElasticsearchIlle…
2103c8f 
…galStateException` in favor of the JDK one

Related to elastic/elasticsearch#10794

Closes #41.
dadoonet added a commit to elastic/elasticsearch-analysis-icu that referenced this issue Apr 29, 2015
@dadoonet
Remove ElasticsearchIllegalArgumentException and `ElasticsearchIlle…
6b7b7e3 
…galStateException` in favor of the JDK one

Related to elastic/elasticsearch#10794

Closes #50.
@lcawl lcawl added :Core/Infra/Core Core issues without another label and removed :Exceptions labels Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@s1monw s1monw

Labels
:Core/Infra/Core Core issues without another label >enhancement v2.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove ElasticsearchIAE and ElasticsearchISE s1monw/elasticsearch
5 participants
@dakrone @clintongormley @dadoonet @s1monw @lcawl