Remove ElasticsearchIAE and ElasticsearchISE #10862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 would be nice in the future to nuke lines of 'import java.lang.IllegalArgumentException;' and 'import java.lang.IllegalStateException;' too. But there are probably unnecessary imports in other places as well. In some cases (e.g. IndexMetaData), there are throws clauses for these exceptions, which is a bit wierd too and something to revisit. I think it confuses lots of IDEs into generating separate catch blocks (we saw this forever from users list in lucene), and |
|
LGTM, +1 to @rmuir suggestions |
|
Huge +1 too. Nuking the java.lang imports should be easy to automate. |
s1monw
force-pushed
the
issues/10794
branch
2 times, most recently
from
4c21165
to
e34db4d
Compare
This commit removes ElasticsearchIAE and ElasticsearchISE in favor of the JDKs IAE and ISE. Closes elastic#10794
This commit removes unused thorws statements when RuntimeExceptions are mentioned in the throws statement. It also removes obsolete import statements for java.lang.IllegalArgumentException and java.lang.IllegalStateException
lcawl
added
:Core/Infra/Core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes ElasticsearchIAE and ElasticsearchISE in favor of
the JDKs IAE and ISE.
Closes #10794