Adapt pluginmanager to the new world

[rmuir]

Now that plugins have some structure / e.g. required descriptor file, make pluginmanager strict and prevent mistakes from screwing up the installation.

Today it is still lenient and will basically accept any .zip or .jar and who knows what will happen. There is no sense in leniency, PluginService is going to reject any bullshit on startup.

• Read/validate descriptor file, remove heuristics around _site or not
• Look for descriptor file to find the plugin "root" in a simpler/safer way, when plugin-a.zip expands to plugin-a/ and we have to deal with that.
• Proper jar hell check for non-isolated plugins: we check the candidate against any other non-isolated plugins already installed.
• Fix tests to not use embedded zip files, instead create them on the fly for testing.

[jaymode]

maybe add directory or dir at the end of the string

[jaymode]

left a few minor comments about exception messages. other than that LGTM

[clintongormley]

Contacting community plugin authors:

@sscarduzio, @lukas-vlcek, @mobz, @jprante, @royrusso, @andrewvc, @lmenezes, @karmi, @grantr, @shikhar, @grmblfrz, @yakaz, @synhershko, @medcl, @chytreg, @imotov, @duydo, @carrot2, @wikimedia, @kzwang, @YannBrrd, @NLPchina, @codelibs

Hi all

Just to let you know about a breaking change coming to plugins in 2.0. Each plugin will require a top-level plugin-descriptor.properties which declares metadata about the plugin. The details can be found here:

https://github.com/elastic/elasticsearch/blob/master/dev-tools/src/main/resources/plugin-metadata/plugin-descriptor.properties

Also, site plugins will need to have a _site directory. We no longer move anything that isn't a jar into an auto-created _site dir.

[clintongormley]

@sscarduzio, @lukas-vlcek, @mobz, @jprante, @royrusso, @andrewvc, @lmenezes, @karmi, @grantr, @shikhar, @grmblfrz, @yakaz, @synhershko, @medcl, @chytreg, @imotov, @duydo, @carrot2, @wikimedia, @kzwang, @YannBrrd, @NLPchina, @codelibs

Sorry: updated link (this is still in the process of being merged, but wanted to make sure you were made aware of it as soon as possible):

https://github.com/rmuir/elasticsearch/blob/plugin_java_version/dev-tools/src/main/resources/plugin-metadata/plugin-descriptor.properties

[synhershko]

Ack, thanks Clinton

[jprante]

I saw this yesterday :) https://twitter.com/xbib/status/624236671551283201

Just a side note, for testing custom jvm plugins, it is also important to add the plugin class name to the key plugin.types to the node settings to get it loaded, because auto-loading from classpath has been disabled. Like this:

settingsBuilder()
                .put("cluster.name", cluster)
                .put("path.home", getHome())
                .put("plugin.types", MyCustomPlugin.class.getName())
                .build();

Will a blog post follow to instruct the new plugin authoring?

[clintongormley]

thanks @jprante - i'm in the process of redoing the plugin docs for 2.0 (see #12040) and I'll update this PR to include documentation.

(btw, why are none of your plugins listed? :) )

[jprante]

@clintongormley I'm not sure, maybe they are not important, maybe I'm too lazy to work through the stuff and submit pull requests. I can't even properly document my plugins for myself or write blog posts :( I know it's really a shame.

[lmenezes]

👍

[YannBrrd]

Ok. I'll release a new version asap. :-)

Le sam. 25 juil. 2015 à 23:03, leonardo menezes notifications@github.com
a écrit :

[image: 👍]

—
Reply to this email directly or view it on GitHub
#12408 (comment)
.

Cordialement,
Yann Barraud

[duydo]

Well noted. Thank @clintongormley for your information :-)

[YannBrrd]

@clintongormley @rmuir @imotov where are the Cache, CacheBuilder & ElasticsearchIllegalArgumentException gone ?
How do I manage cached configuration now ?

[jprante]

@YannBrrd Cache/CacheBuilder classes are part of Guava, and you can use the dependency package of Guava, com.google.common.cache. Instead of ElasticsearchIllegalArgumentException you can either use java.lang.IllegalArgumentException or use the checks in com.google.common.base.Preconditions

[YannBrrd]

Nice thanks !

Le dim. 13 sept. 2015 12:34, Jörg Prante notifications@github.com a
écrit :

@YannBrrd https://github.com/YannBrrd Cache/CacheBuilder classes are
part of Guava, and you can use the dependency package of Guava,
com.google.common.cache. Instead of ElasticsearchIllegalArgumentException
you can either use java.lang.IllegalArgumentException or use the checks
in com.google.common.base.Preconditions

—
Reply to this email directly or view it on GitHub
#12408 (comment)
.

Cordialement,
Yann Barraud

[YannBrrd]

\o/
https://github.com/YannBrrd/elasticsearch-entity-resolution/tree/2.0

[sscarduzio]

Hi guys, Readonly REST plugin is updated as well. 👍

https://github.com/sscarduzio/elasticsearch-readonlyrest-plugin

[YannBrrd]

@jprante how do I fix the jar hell after adding guava as a dependency ? Integrations tests failing... /o\

Edit : My bad, was fixed as per ES issue