Stop iterating on sub readers if the parent is found in TopChildrenQuery #1843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@martijnvg is this PR still relevant? |
|
@clintongormley This PR is still relevant, but it is very outdated. I lost track of this one, but I think with a simple change this optimisation can be achieved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some comment saying "we found a match, add it and break", but there's no actual break.
In the suggested patch, it rewrote the loop to make the loop ending more explicit. I could have just added a "break", but I don't like much "break". Well, actually the main reason is this patch avoid too much diff with fetch-children branch :).