Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop iterating on sub readers if the parent is found in TopChildrenQuery #1843

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@nlalevee
Copy link
Contributor

nlalevee commented Apr 4, 2012

There are some comment saying "we found a match, add it and break", but there's no actual break.

In the suggested patch, it rewrote the loop to make the loop ending more explicit. I could have just added a "break", but I don't like much "break". Well, actually the main reason is this patch avoid too much diff with fetch-children branch :).

@clintongormley

This comment has been minimized.

Copy link
Member

clintongormley commented Jul 8, 2014

@martijnvg is this PR still relevant?

@martijnvg

This comment has been minimized.

Copy link
Member

martijnvg commented Jul 16, 2014

@clintongormley This PR is still relevant, but it is very outdated. I lost track of this one, but I think with a simple change this optimisation can be achieved.

@martijnvg martijnvg closed this in ca7fa4f Jul 16, 2014

martijnvg added a commit that referenced this pull request Jul 16, 2014

Query: When parent doc is found stop iterating over segments and cont…
…inue with the next top matching child doc.

The parent doc has been found and there is no need to check subsequent segments.

Closes #6895
Closes #1843

@martijnvg martijnvg removed the review label Jul 16, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.