Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove StandardHtmlAnalyzer #4704

Closed
clintongormley opened this issue Jan 13, 2014 · 5 comments
Closed

Remove StandardHtmlAnalyzer #4704

clintongormley opened this issue Jan 13, 2014 · 5 comments
Assignees
Labels
>breaking good first issue low hanging fruit help wanted adoptme :Search/Analysis How text is split into tokens

Comments

@clintongormley
Copy link

The StandardHtmlAnalyzer has never been documented and has been implemented with limited support for configuration.

Its functionality is easy to replicate (in a more flexible way) using the HTMLStripCharFilter, so we should remove this analyzer.

@clintongormley
Copy link
Author

References #4704 and #4699

@s1monw
Copy link
Contributor

s1monw commented Jan 13, 2014

++

@s1monw
Copy link
Contributor

s1monw commented Jan 13, 2014

actually I think we can't easily do that and we need to think more about how we handle deprecated analyzers in the future. For now I think we should just fix #4699 WDYT @clintongormley

@clintongormley
Copy link
Author

I think we can deprecate this now (5.x). We'll need to support it for existing indices in 6.0, but not allow new indices to be created with it, and we can remove in 7.0.

Shepard1212 added a commit to Shepard1212/elasticsearch that referenced this issue Mar 23, 2017
Since the StandardHtmlAnalyzer's functionality is easy to replicate using the HTMLStripCharFilter, so I remove this analyzer.
johtani added a commit to johtani/elasticsearch that referenced this issue Oct 26, 2018
Deprecate only Standard Html Strip Analyzer
If user create index with the analyzer, es output deprecation log.
We will remove it in 8.0

Related elastic#4704
johtani added a commit to johtani/elasticsearch that referenced this issue Oct 27, 2018
Move rest test under analysis-common

Related elastic#4704
johtani added a commit to johtani/elasticsearch that referenced this issue Nov 1, 2018
johtani added a commit to johtani/elasticsearch that referenced this issue Nov 1, 2018
Deprecate only Standard Html Strip Analyzer
If user create index with the analyzer since 7.0, es throws an exception.
If an index was created before 7.0, es issue deprecation log
We will remove it in 8.0

Related elastic#4704
johtani added a commit to johtani/elasticsearch that referenced this issue Nov 2, 2018
Deprecate only Standard Html Strip Analyzer
If user create index with the analyzer since 7.0, es throws an exception.
If an index was created before 7.0, es issue deprecation log
We will remove it in 8.0

Related elastic#4704
johtani added a commit to johtani/elasticsearch that referenced this issue Nov 2, 2018
Deprecate only Standard Html Strip Analyzer
If user create index with the analyzer since 7.0, es throws an exception.
If an index was created before 7.0, es issue deprecation log
We will remove it in 8.0

Related elastic#4704
johtani added a commit to johtani/elasticsearch that referenced this issue Nov 5, 2018
Use expectThrows
Change versions for deprecation log

Related elastic#4704
johtani added a commit to johtani/elasticsearch that referenced this issue Nov 5, 2018
johtani added a commit to johtani/elasticsearch that referenced this issue Nov 8, 2018
Change to use getPreviousVersion

Related elastic#4704
johtani added a commit to johtani/elasticsearch that referenced this issue Nov 14, 2018
Deprecate only Standard Html Strip Analyzer
If user create index with the analyzer since 7.0, es throws an exception.
If an index was created before 7.0, es issue deprecation log
We will remove it in 8.0

Related elastic#4704
johtani added a commit to johtani/elasticsearch that referenced this issue Nov 14, 2018
Use expectThrows
Change versions for deprecation log

Related elastic#4704
johtani added a commit to johtani/elasticsearch that referenced this issue Nov 14, 2018
johtani added a commit to johtani/elasticsearch that referenced this issue Nov 14, 2018
Change to use getPreviousVersion

Related elastic#4704
johtani added a commit to johtani/elasticsearch that referenced this issue Jan 8, 2019
Deprecate only Standard Html Strip Analyzer
If user create index with the analyzer since 7.0, es throws an exception.
If an index was created before 7.0, es issue deprecation log
We will remove it in 8.0

Related elastic#4704
johtani added a commit to johtani/elasticsearch that referenced this issue Jan 8, 2019
Use expectThrows
Change versions for deprecation log

Related elastic#4704
johtani added a commit to johtani/elasticsearch that referenced this issue Jan 8, 2019
johtani added a commit to johtani/elasticsearch that referenced this issue Jan 8, 2019
Change to use getPreviousVersion

Related elastic#4704
johtani added a commit to johtani/elasticsearch that referenced this issue Jan 8, 2019
johtani added a commit to johtani/elasticsearch that referenced this issue Jan 8, 2019
Change version to 7_0_0 and remove non use logger

Related elastic#4704
johtani added a commit to johtani/elasticsearch that referenced this issue Jan 8, 2019
Change version to 7_0_0 and fix deprecationlogger error

Related elastic#4704
johtani added a commit that referenced this issue Jan 9, 2019
* [Analysis] Deprecate Standard Html Strip Analyzer

Deprecate only Standard Html Strip Analyzer
If user create index with the analyzer since 7.0, es throws an exception.
If an index was created before 7.0, es issue deprecation log
We will remove it in 8.0

Related #4704
johtani added a commit to johtani/elasticsearch that referenced this issue Jan 11, 2019
johtani added a commit to johtani/elasticsearch that referenced this issue Jan 11, 2019
johtani added a commit to johtani/elasticsearch that referenced this issue Jan 15, 2019
Move deprecation message to CommonAnalysisPlugin

Related elastic#4704

(cherry picked from commit 38b698d)
johtani added a commit to johtani/elasticsearch that referenced this issue Jan 17, 2019
johtani added a commit to johtani/elasticsearch that referenced this issue Jan 18, 2019
johtani added a commit that referenced this issue Jan 22, 2019
Backport #26719 to 6.x

Related #4704

(cherry picked from commit 38b698d)
@jimczi jimczi removed this from Search & Aggs in Background tasks Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>breaking good first issue low hanging fruit help wanted adoptme :Search/Analysis How text is split into tokens
Projects
None yet
Development

No branches or pull requests

5 participants