Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove (mostly) unused 'failure' member from ShardSearchFailure. #6861

Closed
wants to merge 1 commit into from
Closed

Remove (mostly) unused 'failure' member from ShardSearchFailure. #6861

wants to merge 1 commit into from

Conversation

rjernst
Copy link
Member

@rjernst rjernst commented Jul 14, 2014

closes #6837

@s1monw
Copy link
Contributor

s1monw commented Jul 15, 2014

this looks good to me - I wonder what @kimchy thinks

@s1monw s1monw removed the review label Jul 15, 2014
@kimchy
Copy link
Member

kimchy commented Jul 23, 2014

LGTM

@clintongormley
Copy link

@rjernst want to get this merged in?

@rjernst
Copy link
Member Author

rjernst commented Aug 7, 2014

Yes, will do so shortly.

@rjernst rjernst added enhancement and removed bug labels Aug 7, 2014
@rjernst rjernst closed this in 90d2cb7 Aug 7, 2014
rjernst added a commit that referenced this pull request Aug 7, 2014
@rjernst
Internal: Remove (mostly) unused 'failure' member from ShardSearchFai…
03e9bcf 
…lure.

closes #6837
closes #6861
rjernst added a commit that referenced this pull request Sep 8, 2014
@rjernst @areek
Internal: Remove (mostly) unused 'failure' member from ShardSearchFai…
388d05a 
…lure.

closes #6837
closes #6861
@clintongormley clintongormley changed the title Remove (mostly) unused 'failure' member from ShardSearchFailure. Internal: Remove (mostly) unused 'failure' member from ShardSearchFailure. Sep 8, 2014
@rjernst rjernst deleted the fix/6837 branch January 21, 2015 23:22
@clintongormley clintongormley changed the title Internal: Remove (mostly) unused 'failure' member from ShardSearchFailure. Remove (mostly) unused 'failure' member from ShardSearchFailure. Jun 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
>enhancement v1.4.0.Beta1 v2.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

failure member in ShardSearchFailure is never serialized
4 participants
@rjernst @s1monw @kimchy @clintongormley