Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking change not documented in release notes #7647

Closed
GlenRSmith opened this issue Sep 8, 2014 · 0 comments
Closed

Breaking change not documented in release notes #7647

GlenRSmith opened this issue Sep 8, 2014 · 0 comments
Assignees
@GaelTadh

Comments

@GlenRSmith
Copy link
Contributor

Somewhere between v1.2.2 and v1.3.1 (I suspect 1.3.0), the DSL for _search/template changed such that, for a template that is deployed to the scripts directory in the file system has to be specified by:

{
"params": {...},
"template": {
"file": "simple"
}
}

instead of

{
"params": {...},
"template": "simple"
}'

This is a breaking change in either direction (neither form works for both versions).

This is not identified in the release notes on the downloads page.
@GaelTadh GaelTadh mentioned this issue Sep 18, 2014
Closed
GaelTadh added a commit to GaelTadh/elasticsearch that referenced this issue Sep 19, 2014
@GaelTadh
Indexed Scripts/Templates : Cleanup
5c39645 
This contains several cleanups to the indexed scripts.
Remove the unused FetchSourceContext from the Get request..
Add lang,_version,_id to the REST GET API.
Removes the routing from GetIndexedScriptRequest since the script index is a single shard that is replicated across all nodes.
Fix backward compatible template file reference
Before 1.3.0 on disk scripts could be referenced by requesting
````
_search/template

{
  "template" : "ondiskscript"
}
````
This was broken in 1.3.0 by requiring
````
{
  "template" :
  {
    "file" : "ondiskscript"
  }
}
````
This commit restores the previous behavior.
Remove support for preference, realtime and refresh
These parameters don't make sense anymore for indexed scripts as we always force the preference to _local and
always refresh after a Put to the indexed scripts index.

Closes elastic#7568
Closes elastic#7559
Closes elastic#7647
Closes elastic#7567
GaelTadh added a commit that referenced this issue Sep 19, 2014
@GaelTadh
Indexed Scripts/Templates : Cleanup
af74a8b 
This contains several cleanups to the indexed scripts.
Remove the unused FetchSourceContext from the Get request..
Add lang,_version,_id to the REST GET API.
Removes the routing from GetIndexedScriptRequest since the script index is a single shard that is replicated across all nodes.
Fix backward compatible template file reference
Before 1.3.0 on disk scripts could be referenced by requesting
````
_search/template

{
  "template" : "ondiskscript"
}
````
This was broken in 1.3.0 by requiring
````
{
  "template" :
  {
    "file" : "ondiskscript"
  }
}
````
This commit restores the previous behavior.
Remove support for preference, realtime and refresh
These parameters don't make sense anymore for indexed scripts as we always force the preference to _local and
always refresh after a Put to the indexed scripts index.

Closes #7568
Closes #7559
Closes #7647
Closes #7567
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GaelTadh GaelTadh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GlenRSmith @GaelTadh