Cleaned up various issues #7787
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| protected String getVersionFieldName() { return "_version"; } | ||
|
|
||
| protected String getLangFieldName() { return "lang"; } |
There was a problem hiding this comment.
can we just use constants for this?
|
those are good cleanups - can we get them into |
|
I created issue #7789 to track the BWC test for templates. |
|
left some more comments |
|
@GaelTadh I removed the review tag just FYI |
|
I made the updates. |
|
LGTM |
This contains several cleanups to the indexed scripts.
Remove the unused FetchSourceContext from the Get request..
Add lang,_version,_id to the REST GET API.
Removes the routing from GetIndexedScriptRequest since the script index is a single shard that is replicated across all nodes.
Fix backward compatible template file reference
Before 1.3.0 on disk scripts could be referenced by requesting
````
_search/template
{
"template" : "ondiskscript"
}
````
This was broken in 1.3.0 by requiring
````
{
"template" :
{
"file" : "ondiskscript"
}
}
````
This commit restores the previous behavior.
Remove support for preference, realtime and refresh
These parameters don't make sense anymore for indexed scripts as we always force the preference to _local and
always refresh after a Put to the indexed scripts index.
Closes elastic#7568
Closes elastic#7559
Closes elastic#7647
Closes elastic#7567
GaelTadh
force-pushed
the
indexedscript-cleanup
branch
from
c2e7e92
to
5c39645
Compare
clintongormley
changed the title
clintongormley
changed the title
clintongormley
added
:Core/Infra/Scripting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cleanup to close issues around the indexed scripts API
This closes :
#7560
#7568
#7559
#7647
#7567