Fix conflict when updating mapping with _all disabled #8426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_all reports a conflict since elastic#7377. However, it was not checked if _all was actually configured in the updated mapping. Therefore whenever _all was disabled a mapping could not be updated unless _all was again added to the updated mapping. Also, add enabled setting to mapping always whenever enabled was set explicitely. closes elastic#8423
|
LGTM. |
|
@brwe want to get this in? |
brwe
added a commit
that referenced
this pull request
Nov 20, 2014
_all reports a conflict since #7377. However, it was not checked if _all was actually configured in the updated mapping. Therefore whenever _all was disabled a mapping could not be updated unless _all was again added to the updated mapping. Also, add enabled setting to mapping always whenever enabled was set explicitely. closes #8423 closes #8426
brwe
added a commit
that referenced
this pull request
Nov 20, 2014
_all reports a conflict since #7377. However, it was not checked if _all was actually configured in the updated mapping. Therefore whenever _all was disabled a mapping could not be updated unless _all was again added to the updated mapping. Also, add enabled setting to mapping always whenever enabled was set explicitely. closes #8423 closes #8426
clintongormley
added
>bug
v1.4.1
v1.5.0
v2.0.0-beta1
:Search Foundations/Mapping
clintongormley
changed the title
clintongormley
changed the title
|
It seems that it's not possible to disable the
Is this intentional? |
|
Hi @rayward Yes it is intentional. In fact from 2.0, the only time you'll be able to enable or disable the _all field is when you create the mapping. |
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
_all reports a conflict since elastic#7377. However, it was not checked if _all was actually configured in the updated mapping. Therefore whenever _all was disabled a mapping could not be updated unless _all was again added to the updated mapping. Also, add enabled setting to mapping always whenever enabled was set explicitely. closes elastic#8423 closes elastic#8426
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_all reports a conflict since #7377. However, it was not checked if _all
was actually configured in the updated mapping. Therefore whenever _all
was disabled a mapping could not be updated unless _all was again added to the
updated mapping.
Also, add enabled setting to mapping always whenever enabled was set explicitely.
closes #8423