Report conflict when merging _all field mapping and throw exception when doc_values specified
#7377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- _all field was never merged when mapping was updated and no conflict reported - _all accepted doc_values format although it is always tokenized relates to elastic#777
|
LGTM |
clintongormley
changed the title
_all field mapping and throw exception when doc_values specified
clintongormley
changed the title
_all field mapping and throw exception when doc_values specified_all field mapping and throw exception when doc_values specified
brwe
added a commit
to brwe/elasticsearch
that referenced
this pull request
Nov 10, 2014
_all reports a conflict since elastic#7377. However, it was not checked if _all was actually configured in the updated mapping. Therefore whenever _all was disabled a mapping could not be updated unless _all was again added to the updated mapping. Also, add enabled setting to mapping always whenever enabled was set explicitely. closes elastic#8423
brwe
added a commit
that referenced
this pull request
Nov 20, 2014
_all reports a conflict since #7377. However, it was not checked if _all was actually configured in the updated mapping. Therefore whenever _all was disabled a mapping could not be updated unless _all was again added to the updated mapping. Also, add enabled setting to mapping always whenever enabled was set explicitely. closes #8423 closes #8426
brwe
added a commit
that referenced
this pull request
Nov 20, 2014
_all reports a conflict since #7377. However, it was not checked if _all was actually configured in the updated mapping. Therefore whenever _all was disabled a mapping could not be updated unless _all was again added to the updated mapping. Also, add enabled setting to mapping always whenever enabled was set explicitely. closes #8423 closes #8426
brwe
added a commit
that referenced
this pull request
Nov 20, 2014
_all reports a conflict since #7377. However, it was not checked if _all was actually configured in the updated mapping. Therefore whenever _all was disabled a mapping could not be updated unless _all was again added to the updated mapping. Also, add enabled setting to mapping always whenever enabled was set explicitely. closes #8423 closes #8426
clintongormley
added
the
:Search/Mapping
clintongormley
changed the title
_all field mapping and throw exception when doc_values specified_all field mapping and throw exception when doc_values specified
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
_all reports a conflict since elastic#7377. However, it was not checked if _all was actually configured in the updated mapping. Therefore whenever _all was disabled a mapping could not be updated unless _all was again added to the updated mapping. Also, add enabled setting to mapping always whenever enabled was set explicitely. closes elastic#8423 closes elastic#8426
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to #777
Note that the exception when
doc_valueswas configured is new. This might cause problems for users that configured it and upgrade since the old mapping cannot be parsed anymore after this change.