Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report conflict when merging `_all` field mapping and throw exception when doc_values specified #7377

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@brwe
Copy link
Contributor

commented Aug 21, 2014

  • _all field was never merged when mapping was updated and no conflict reported
  • _all accepted doc_values format although it is always tokenized. this setting was ignored before.

relates to #777

Note that the exception when doc_values was configured is new. This might cause problems for users that configured it and upgrade since the old mapping cannot be parsed anymore after this change.

_all: report conflict on merge and throw exception on doc_values
- _all field was never merged when mapping was updated and no conflict reported
- _all accepted doc_values format although it is always tokenized

relates to #777
@jpountz

This comment has been minimized.

Copy link
Contributor

commented Aug 26, 2014

LGTM

@jpountz jpountz removed the review label Aug 26, 2014

brwe added a commit that referenced this pull request Aug 26, 2014

_all: report conflict on merge and throw exception on doc_values
- _all field was never merged when mapping was updated and no conflict reported
- _all accepted doc_values format although it is always tokenized

relates to #777
closes #7377

@brwe brwe closed this in d7b8d17 Aug 26, 2014

@brwe brwe added the enhancement label Aug 27, 2014

brwe added a commit that referenced this pull request Sep 8, 2014

_all: report conflict on merge and throw exception on doc_values
- _all field was never merged when mapping was updated and no conflict reported
- _all accepted doc_values format although it is always tokenized

relates to #777
closes #7377

@clintongormley clintongormley changed the title _all: report conflict on merge and throw exception on doc_values Mappig: Report conflict when merging `_all` field mapping and throw exception when doc_values specified Sep 8, 2014

@clintongormley clintongormley changed the title Mappig: Report conflict when merging `_all` field mapping and throw exception when doc_values specified Mapping: Report conflict when merging `_all` field mapping and throw exception when doc_values specified Sep 8, 2014

brwe added a commit to brwe/elasticsearch that referenced this pull request Nov 10, 2014

[root mappers] fix conflict when updating mapping with _all disabled
_all reports a conflict since elastic#7377. However, it was not checked if _all
was actually configured in the updated mapping. Therefore whenever _all
was disabled a mapping could not be updated unless _all was again added to the
updated mapping.
Also, add enabled setting to mapping always whenever enabled was set explicitely.

closes elastic#8423

mfussenegger added a commit to crate/elasticsearch that referenced this pull request Nov 11, 2014

fix conflict when updating mapping with _all disabled
_all reports a conflict since elastic#7377. However, it was not checked if _all
was actually configured in the updated mapping. Therefore whenever _all
was disabled a mapping could not be updated unless _all was again added to the
updated mapping.
Also, add enabled setting to mapping always whenever enabled was set explicitely.

closes elastic#8423

brwe added a commit that referenced this pull request Nov 20, 2014

[root mappers] fix conflict when updating mapping with _all disabled
_all reports a conflict since #7377. However, it was not checked if _all
was actually configured in the updated mapping. Therefore whenever _all
was disabled a mapping could not be updated unless _all was again added to the
updated mapping.
Also, add enabled setting to mapping always whenever enabled was set explicitely.

closes #8423
closes #8426

brwe added a commit that referenced this pull request Nov 20, 2014

[root mappers] fix conflict when updating mapping with _all disabled
_all reports a conflict since #7377. However, it was not checked if _all
was actually configured in the updated mapping. Therefore whenever _all
was disabled a mapping could not be updated unless _all was again added to the
updated mapping.
Also, add enabled setting to mapping always whenever enabled was set explicitely.

closes #8423
closes #8426

brwe added a commit that referenced this pull request Nov 20, 2014

[root mappers] fix conflict when updating mapping with _all disabled
_all reports a conflict since #7377. However, it was not checked if _all
was actually configured in the updated mapping. Therefore whenever _all
was disabled a mapping could not be updated unless _all was again added to the
updated mapping.
Also, add enabled setting to mapping always whenever enabled was set explicitely.

closes #8423
closes #8426

@clintongormley clintongormley changed the title Mapping: Report conflict when merging `_all` field mapping and throw exception when doc_values specified Report conflict when merging `_all` field mapping and throw exception when doc_values specified Jun 7, 2015

mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015

[root mappers] fix conflict when updating mapping with _all disabled
_all reports a conflict since elastic#7377. However, it was not checked if _all
was actually configured in the updated mapping. Therefore whenever _all
was disabled a mapping could not be updated unless _all was again added to the
updated mapping.
Also, add enabled setting to mapping always whenever enabled was set explicitely.

closes elastic#8423
closes elastic#8426
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.