Unified Highlighter to support matched_fields #107640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support to the Uunified highlighter to combine matches on multiple fields to highlight a single field: "matched_fields". Based on Lucene PR: apache/lucene#13268 Lucene PR is based on the concept of masked fields where masked fields are different from the original highlighted field. This PR in Elasticsearch uses the already existing highlighter parameter "matched_fields" Closes elastic#5172
mayya-sharipova
added
>enhancement
:Search/Highlighting
|
Pinging @elastic/es-search (Team:Search) |
|
@jimczi What do you think of reusing the already existing parameter of |
|
+1 to reuse |
jimczi
reviewed
Apr 22, 2024
benwtrent
reviewed
Apr 22, 2024
...src/yamlRestTest/resources/rest-api-spec/test/search.highlight/60_unified_matched_fields.yml
Outdated
Show resolved
Hide resolved
…hter-multiple-fields
…hter-multiple-fields
…hter-multiple-fields
mayya-sharipova
force-pushed
the
uhighlighter-multiple-fields
branch
from
baa00a1
to
ce905fe
Compare
|
@jimczi @benwtrent Thanks for your feedback. I've addressed your comments. This is ready for another set of reviews. |
|
@jimczi Thanks for the feedback so far, I am wondering if you have any additional comments |
|
Please add an entry to the change log too |
|
@mayya-sharipova yes, please manually add a PR changes entry. This way we can keep track of features added when the Lucene snapshot branch is merged into main. |
…hter-multiple-fields
…hter-multiple-fields
|
@elasticsearchmachine run elasticsearch-ci/part-1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to the Uunified highlighter to combine matches on multiple fields to highlight a single field: "matched_fields".
Based on Lucene PR: apache/lucene#13268
Lucene PR is based on the concept of masked fields where masked fields are different from the original highlighted field. This PR in Elasticsearch uses the already existing highlighter parameter "matched_fields"
Closes #5172