[ML] Transition to typeless (mapping) APIs #39573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core |
ML has historically used doc as the single mapping type but reindex in 7.x will change the mapping to _doc. Switching to the typeless APIs handles the case where the mapping type is either doc or _doc. This change removes deprecated typed usages.
davidkyle
force-pushed
the
ml-typeless-7x
branch
from
415e402
to
2726736
Compare
|
run elasticsearch-ci/bwc |
…9574) Following elastic#39256 some of these tests were generating errors when indexing documents. For consistency it's best that all of them use typeless APIs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes deprecated usage of types in the APIs and resolves a reindex issue with the upgrade assistant in 7 to wit:
docas the single mapping type by convention_docunless a target type is specifieddoctype after reindex a mapping conflict occurs as the index would have 2 typesdocand_doc. This is the cause of [ML] Need to cope with .ml-config being an alias #38796Depending on whether or not the upgrade assistant has been run the single mapping type of the ml indices may be
docor_doc, moving to the typeless APIs largely covers this situation however, there is the case of updating the results index mapping on job creation in which case the new mapping must have the same type as the old otherwise the index will have 2 types of mappingsBackport of #39256