Version types EXTERNAL & EXTERNAL_GTE test for version equality in read operation & disallow them in the Update API
#5929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n read operation & disallow them in the Update API Separate version check logic for reads and writes for all version types, which allows different behavior in these cases. Change `VersionType.EXTERNAL` & `VersionType.EXTERNAL_GTE` to behave the same as `VersionType.INTERNAL` for read operations. The previous behavior was fit for writes but is useless in reads. This commit also makes the usage of `EXTERNAL` & `EXTERNAL_GTE` in the update api raise a validation error as it make cause data to be lost. Closes elastic#5663 , closes elastic#5661
| @@ -165,6 +165,14 @@ including: | |||
| Support `_source` to return the full updated | |||
| source. | |||
|
|
|||
| `version` & `version_type`:: the Update API uses the Elasticsearch's versioning | |||
There was a problem hiding this comment.
this should maybe have a since tag to make sure folks know when it was added
There was a problem hiding this comment.
it was already there, though not documented. Added in 1.0.0 beta
|
I left some comments, looks good but it seems like it has lots of unrelated changes? |
|
ok good! I think this is good to go! LGTM |
bleskes
added a commit
that referenced
this pull request
Apr 25, 2014
…n read operation & disallow them in the Update API Separate version check logic for reads and writes for all version types, which allows different behavior in these cases. Change `VersionType.EXTERNAL` & `VersionType.EXTERNAL_GTE` to behave the same as `VersionType.INTERNAL` for read operations. The previous behavior was fit for writes but is useless in reads. This commit also makes the usage of `EXTERNAL` & `EXTERNAL_GTE` in the update api raise a validation error as it make cause data to be lost. Closes #5663 , Closes #5661, Closes #5929
clintongormley
added
the
:Distributed/CRUD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate version check logic for reads and writes for all version types, which allows different behavior in these cases.
Change
VersionType.EXTERNAL&VersionType.EXTERNAL_GTEto behave the same asVersionType.INTERNALfor read operations.The previous behavior was fit for writes but is useless in reads.
This commit also makes the usage of
EXTERNAL&EXTERNAL_GTEin the update api raise a validation error as it make cause data tobe lost.
Closes #5663 , closes #5661