A Get request with a version set should always validate for equality #5663
Assignees
Comments
bleskes
added a commit
to bleskes/elasticsearch
that referenced
this issue
Apr 24, 2014
…n read operation & disallow them in the Update API Separate version check logic for reads and writes for all version types, which allows different behavior in these cases. Change `VersionType.EXTERNAL` & `VersionType.EXTERNAL_GTE` to behave the same as `VersionType.INTERNAL` for read operations. The previous behavior was fit for writes but is useless in reads. This commit also makes the usage of `EXTERNAL` & `EXTERNAL_GTE` in the update api raise a validation error as it make cause data to be lost. Closes elastic#5663 , closes elastic#5661
bleskes
added a commit
that referenced
this issue
Apr 25, 2014
…n read operation & disallow them in the Update API Separate version check logic for reads and writes for all version types, which allows different behavior in these cases. Change `VersionType.EXTERNAL` & `VersionType.EXTERNAL_GTE` to behave the same as `VersionType.INTERNAL` for read operations. The previous behavior was fit for writes but is useless in reads. This commit also makes the usage of `EXTERNAL` & `EXTERNAL_GTE` in the update api raise a validation error as it make cause data to be lost. Closes #5663 , Closes #5661, Closes #5929
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently we use the same version checking logic for get and indexing requests. The leads to the wrong semantics for the
EXTERNALand theEXTERNAL_TYPEversioning systems. For example, doingGET index/type/1?version=10&version_type=externalwill return the document if it has a version of 9 or less.We should make it return documents only if their version match the specified version.
The text was updated successfully, but these errors were encountered: