Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shard_min_doc_count parameter to terms aggregation #6143

Closed
wants to merge 14 commits into from

Commits on May 13, 2014

  1. refactor: unify terms and significant_terms parsing

    Both need the requiredSize, shardSize, minDocCount and shardMinDocCount.
    Parsing should not be duplicated.
    brwe committed May 13, 2014
    Copy the full SHA
    fd80abc View commit details
    Browse the repository at this point in the history
  2. refactor: make requiredSize, shardSize, minDocCount and shardMinDocCo…

    …unt a single parameter
    
    every class using these parameters has their own member where these four
    are stored. This clutters the code. Because they mostly needed together
    it might make sense to group them.
    I hope that this makes the code more readable and also that if avoids
    errors such as mixing up the int/long parameters in the future.
    brwe committed May 13, 2014
    Copy the full SHA
    ad2d8ba View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    d97f194 View commit details
    Browse the repository at this point in the history
  4. use shard_min_doc_count also in TermsAggregation

    This was discussed in issue elastic#6041 and elastic#5998 .
    brwe committed May 13, 2014
    Copy the full SHA
    869f5d3 View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    438c4f3 View commit details
    Browse the repository at this point in the history
  6. handle defaults only in parser and use names from ParseFields

    squash to commit "refactor: make requiredSize, shardSize, minDocCount and shardMinDocCount a single parameter"
    brwe committed May 13, 2014
    Copy the full SHA
    42c9539 View commit details
    Browse the repository at this point in the history
  7. Move validity checks to BucketCountThresholds and add >=0 check

    squash to commit "refactor: make requiredSize, shardSize, minDocCount and shardMinDocCount a single parameter"
    brwe committed May 13, 2014
    Copy the full SHA
    cbdb9a1 View commit details
    Browse the repository at this point in the history
  8. Copy the full SHA
    e65a245 View commit details
    Browse the repository at this point in the history
  9. Copy the full SHA
    18d79bc View commit details
    Browse the repository at this point in the history

Commits on May 14, 2014

  1. do not expose explicit() in BucketCountThresholds and move builder co…

    …de to BucketCountThresholds
    brwe committed May 14, 2014
    Copy the full SHA
    56bd7d5 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    15af410 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    2324876 View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    38166f2 View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    945482b View commit details
    Browse the repository at this point in the history