New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add shard_min_doc_count
parameter to terms aggregation
#6143
Closed
Closed
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
fd80abc
refactor: unify terms and significant_terms parsing
brwe ad2d8ba
refactor: make requiredSize, shardSize, minDocCount and shardMinDocCo…
brwe d97f194
add failing test for shard_min_doc_count
brwe 869f5d3
use shard_min_doc_count also in TermsAggregation
brwe 438c4f3
add documentation of `shard_min_doc_count`
brwe 42c9539
handle defaults only in parser and use names from ParseFields
brwe cbdb9a1
Move validity checks to BucketCountThresholds and add >=0 check
brwe e65a245
use class Explicit in BucketCountThresholds
brwe 18d79bc
refactor constructors of BucketCountThresholds
brwe 56bd7d5
do not expose explicit() in BucketCountThresholds and move builder co…
brwe 15af410
set shard_size and size to Integer.MAX if they are 0
brwe 2324876
Update docs to explain default settings
brwe 38166f2
add coming [1.2.0] to the changes
brwe 945482b
add coming[1.2.0] also to significant terms
brwe File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add
coming[1.2.0]
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done