Object and Type parsing: Fix include_in_all in type #6353
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
include_in_all can also be set on type level (root object). This fixes a regression introduced in elastic#6093 closes elastic#6304
|
the fix looks good but I wonder if you want add a test for the other cases we can set this? |
|
SimpleAllMapperTests already has some tests that cover that, for example testMultiField_includeInAllSetToFalse(). Do you still think we need another one? |
|
no in that case I think I am good.... LGTM |
gmarz
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Jul 1, 2014
clintongormley
added
>regression
v2.0.0-beta1
v1.3.0
v1.2.1
:Search/Mapping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
include_in_all can also be set on type level (root object).
This fixes a regression introduced in #6093
closes #6304