Move index templates api back to indices category and make put template and create index implement IndicesRequest #7378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…put template and create index implement IndicesRequest
| @@ -27,7 +27,7 @@ | |||
| public class DeleteIndexTemplateAction extends IndicesAction<DeleteIndexTemplateRequest, DeleteIndexTemplateResponse, DeleteIndexTemplateRequestBuilder> { | |||
|
|
|||
| public static final DeleteIndexTemplateAction INSTANCE = new DeleteIndexTemplateAction(); | |||
| public static final String NAME = "cluster:admin/template/delete"; | |||
There was a problem hiding this comment.
this is a BW break right? I think we can't do this on 1.4?
There was a problem hiding this comment.
it's ok since we have action names mapping that makes it work in a bw compatible manner. We had already changed the action names in #7105 in a bw comp manner (change not released yet, will be with 1.4).
|
I left two comments regarding BWC but other than that I think it's ok to add for consistency? |
|
ok fair enough LGTM |
javanna
added a commit
that referenced
this pull request
Aug 22, 2014
…put template and create index implement IndicesRequest Closes #7378
javanna
added a commit
that referenced
this pull request
Sep 8, 2014
…put template and create index implement IndicesRequest Closes #7378
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.