Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

span_near query should accept slop = -1 (bis) #3673

Closed
iksnalybok opened this issue Sep 12, 2013 · 5 comments
Closed

span_near query should accept slop = -1 (bis) #3673

iksnalybok opened this issue Sep 12, 2013 · 5 comments
Assignees
@javanna
Labels
>enhancement v0.90.6 v1.0.0.Beta1

Comments

@iksnalybok
Copy link
Contributor

Hi,

Previous fix (#3122) for issue #3079 (span_near query should accept slop = -1) is incomplete. Similar fix (e.g change int slop = -1; into Integer slop = null;) should also be applied in src/main/java/org/elasticsearch/index/query/SpanNearQueryBuilder.java.

Could you please also make the fix available in the 0.90.x branch ?

Thanks
@ghost ghost assigned javanna Sep 12, 2013
@javanna
Copy link
Member

javanna commented Sep 12, 2013

Right I see what you mean. @iksnalybok do you want to send a pull request for this?

@iksnalybok
Copy link
Contributor Author

cf pull 3683 (master branch)

NB: do I need to create another for the 0.90.x branch ?

@javanna
Copy link
Member

javanna commented Sep 13, 2013

@iksnalybok one pull request against master is enough, we can then cherry pick the commit to backport it to 0.90. Thanks!

@iksnalybok
Copy link
Contributor Author

I could not clean the pull request log in a reasonable amount of time. Would you mind doing the fix yourself ? Thanks.

@iksnalybok iksnalybok mentioned this issue Sep 20, 2013
Closed
javanna pushed a commit that referenced this issue Sep 20, 2013
@iksnalybok @javanna
Allow slop = -1 in span queries
c6bd023 
Closes #3673
@nik9000
Copy link
Member

nik9000 commented Sep 24, 2013

Does the hack that this allows deserve a documentation update?

@cbuescher cbuescher mentioned this issue Jul 9, 2015
Merged
mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015
@iksnalybok @javanna
Allow slop = -1 in span queries
f0f577c 
Closes elastic#3673
2lambda123 pushed a commit to 2lambda123/elastic-elasticsearch that referenced this issue May 2, 2024
@iksnalybok
fix for elastic/elasticsearch#3673
e517161
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@javanna javanna

Labels
>enhancement v0.90.6 v1.0.0.Beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow slop = -1 in span queries (#3673)
3 participants
@nik9000 @javanna @iksnalybok