Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix optional property handling in DateCard component #1283

Merged
merged 1 commit into from Jan 2, 2024

Conversation

tn3rb
Copy link
Member

@tn3rb tn3rb commented Dec 20, 2023

This PR fixes #1282

@tn3rb tn3rb self-assigned this Dec 20, 2023
@github-actions github-actions bot added the D: EE CORE ☕ domain: Event Espresso Core Plugin label Dec 20, 2023
@tn3rb tn3rb requested a review from alexkuc December 20, 2023 20:50
Copy link
Contributor

@alexkuc alexkuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@alexkuc
Copy link
Contributor

alexkuc commented Dec 23, 2023

Imho, this PR should not be merged until #1281 is fixed because currently we have broken changes in master branch

Edit: please wait for PRs https://github.com/eventespresso/cafe/pull/978 and https://github.com/eventespresso/e2e-tests/pull/38 to be merged to resolve failing E2E tests

@alexkuc alexkuc mentioned this pull request Dec 23, 2023
11 tasks
@kingrio13
Copy link

kingrio13 commented Dec 27, 2023

Hmm, i'm not sure if im doing it right, but im having this problem.
image

here's some problem in console.
index.js:1 Missing field 'status' while writing result {
"id": "VGlja2V0OjMy",
"cacheId": "Ticket:32:658ba51ce7ca38.72710974",
"dbId": 32,
"description": "",
"endDate": "2024-01-26T23:59:00+00:00",
"isDefault": false,
"isExpired": false,
"isFree": true,
"isOnSale": true,
"isPending": true,
"isRequired": false,
"isSoldOut": false,
"isTrashed": false,
"max": -1,
"min": 0,
"name": "Free Ticket",
"order": 0,
"price": 0,
"quantity": 100,
"registrationCount": 0,
"reserved": 0,
"reverseCalculate": false,
"sold": 0,
"startDate": "2023-12-27T04:16:00+00:00",
"userId": "dXNlcjox",
"uses": -1,
"visibility": "PUBLIC",
"__typename": "EspressoTicket"
}

@alexkuc
Copy link
Contributor

alexkuc commented Dec 27, 2023

@kingrio13 Because PR #1277 was already merged, your local Cafe repository needs to point to branch NEW/CORE/datetime-status otherwise there is no backend code to support new statuses

@tn3rb tn3rb merged commit b492c16 into master Jan 2, 2024
24 of 25 checks passed
@tn3rb tn3rb deleted the FIX/date-card-type-error branch January 2, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D: EE CORE ☕ domain: Event Espresso Core Plugin S11: completed 🚀 status
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncaught TypeError: Cannot read properties of undefined (reading 'length') and Uncaught (in promise)
7 participants