Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Event Date Status Selector #1277

Merged
merged 22 commits into from Dec 15, 2023
Merged

New Event Date Status Selector #1277

merged 22 commits into from Dec 15, 2023

Conversation

tn3rb
Copy link
Member

@tn3rb tn3rb commented Nov 30, 2023 •
edited

this PR:

  • requires cafe repo branch NEW/CORE/datetime-status

  • adds a new status selector to the date card sidebar that allows users to manually control the status for an event date

  • date card showing new statuses and status colors
    Screenshot from 2023-11-29 14-50-36

  • status selector popover
    Screenshot from 2023-11-29 14-51-18

  • status selector options
    Screenshot from 2023-11-29 14-52-08

  • status selector help popover
    Screenshot from 2023-11-29 14-51-39

@tn3rb tn3rb self-assigned this Nov 30, 2023
@github-actions github-actions bot added C: assets 💎 category C: automation & deployment ⚙️ category C: data systems 🗑 category C: services 🤝 category C: UI/UX 🚽 category D: EE CORE ☕ domain: Event Espresso Core Plugin D: Packages 📦 domain: Barista Packages labels Nov 30, 2023
@tn3rb tn3rb requested a review from alexkuc November 30, 2023 00:40
@tn3rb tn3rb added T: new feature ✨ type: NEW - new features P3: med priority 😐 priority: medium labels Nov 30, 2023
@tn3rb tn3rb force-pushed the NEW/event-date-status-selector branch from ade50b9 to e12244f Compare December 7, 2023 21:14
alexkuc
alexkuc previously approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@alexkuc alexkuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, added some feedback

domains/core/admin/eventEditor/src/ui/datetimes/datesList/cardView/DatetimeStatus.tsx Show resolved Hide resolved
domains/core/admin/eventEditor/src/ui/datetimes/datesList/cardView/DatetimeStatus.tsx Outdated Show resolved Hide resolved
packages/edtr-services/src/apollo/types.ts Outdated Show resolved Hide resolved
packages/helpers/src/datetimes/getStatusTextLabel.ts Outdated Show resolved Hide resolved
packages/helpers/src/datetimes/statusBgColorClassName.ts Outdated Show resolved Hide resolved
@tn3rb tn3rb requested a review from alexkuc December 11, 2023 18:38
@tn3rb tn3rb requested a review from alexkuc December 13, 2023 18:58
@alexkuc
Copy link
Contributor

alexkuc commented Dec 14, 2023

/run-e2e

alexkuc
alexkuc approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@alexkuc alexkuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tn3rb tn3rb merged commit 97408d9 into master Dec 15, 2023
16 of 24 checks passed
@tn3rb tn3rb deleted the NEW/event-date-status-selector branch December 15, 2023 19:33
This was referenced Dec 18, 2023
Merged
Closed
@alexkuc alexkuc restored the NEW/event-date-status-selector branch December 23, 2023 14:30
@alexkuc
Copy link
Contributor

alexkuc commented Dec 23, 2023

Restoring branch to investigate what has caused the regression

@alexkuc alexkuc mentioned this pull request Dec 27, 2023
Merged
@tn3rb tn3rb deleted the NEW/event-date-status-selector branch January 3, 2024 21:13
tn3rb added a commit that referenced this pull request Apr 22, 2024
@tn3rb @alexkuc
New Event Date Status Selector (#1277)
9946bb3 
Co-authored-by: Alexander Kucheryuk <3331946+alexkuc@users.noreply.github.com>
tn3rb added a commit that referenced this pull request Apr 22, 2024
@tn3rb @alexkuc
New Event Date Status Selector (#1277)
c8aa697 
Co-authored-by: Alexander Kucheryuk <3331946+alexkuc@users.noreply.github.com>
alexkuc added a commit that referenced this pull request Apr 24, 2024
@tn3rb @alexkuc
New Event Date Status Selector (#1277)
9fbec45 
Co-authored-by: Alexander Kucheryuk <3331946+alexkuc@users.noreply.github.com>
tn3rb added a commit that referenced this pull request May 2, 2024
@tn3rb @alexkuc
New Event Date Status Selector (#1277)
f0ebbb6 
Co-authored-by: Alexander Kucheryuk <3331946+alexkuc@users.noreply.github.com>
tn3rb added a commit that referenced this pull request May 8, 2024
@tn3rb @alexkuc
New Event Date Status Selector (#1277)
96a298d 
Co-authored-by: Alexander Kucheryuk <3331946+alexkuc@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexkuc alexkuc alexkuc approved these changes

Assignees

@tn3rb tn3rb

@garthkoyle garthkoyle

@Pebblo Pebblo

@kingrio13 kingrio13

@Saam01 Saam01

Labels
C: assets 💎 category C: automation & deployment ⚙️ category C: data systems 🗑 category C: services 🤝 category C: UI/UX 🚽 category D: EE CORE ☕ domain: Event Espresso Core Plugin D: Packages 📦 domain: Barista Packages P3: med priority 😐 priority: medium S11: completed 🚀 status T: new feature ✨ type: NEW - new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@tn3rb @alexkuc @garthkoyle @eeteamcodebase @Pebblo @kingrio13 @Saam01