UI: Improve archive help and tooltips. #3350
Conversation
timpwbaker
changed the title
|
Thanks @timpwbaker, and welcome.
These are scary words for me in a pull request. I appreciate what you're trying to achieve here and agree that it is a good idea. I'd rather see a commit that fixed the archive help text issue in the simplest way possible, and just copy/pasting the required text strings to the required places seems much simpler in this case. Then the string consistency / I18n issues could be handled in their own PRs. See also: exercism/discussions#113 for some discussion about where the Exercism front end is headed. |
timpwbaker
force-pushed
the
dictionary_with_first_entry_archive_tooltip
branch
from
272e653
to
ed60303
Compare
|
Thanks, It is also helpful for UI changes to include screenshots to help casual reviewers see the effect of the changes. |
|
Thanks! I'm away this weekend but I'll add some images on Monday morning. |
Insti
changed the title
|
Thanks @timpwbaker, this looks great! Just one thing, we also need to mention if the archiving is reversible or not - meaning if I can make the archived exercise back to active. Even I don't know if this can be done 😄 |
|
My feeling is that's a wider UX/UI issue. Explaining whether it's reversible or not seems a little too much information for a tooltip. What does everyone else think? |
|
Screenshots for reference |
Agreed. I guess tooltip is not a good place for this. And unfortunately I cannot think of any other place for this either. Looking for suggestions from others. |
|
How about adding some text on the dashboard. It currently looks like this:
Perhaps if we explain what archiving means there, then we don't need the tooltips. |
timpwbaker
force-pushed
the
dictionary_with_first_entry_archive_tooltip
branch
from
09ef6d6
to
736b9a1
Compare
|
Thanks @kytrinyx I prefer this approach as while I expect - although I could be wrong - most of Exercism's traffic to be desktop (keyboard and mouse) tooltips have very poor usability on touch screens such as tablets and mobiles.
|
There is some confusion around what the archive functionality actually does, and also some concern about maintaining consistency across tooltip text. This commit proposes making use of the i18n gem as it ships with activesupport and will be intuitive to those from a rails background. It would also support providing translations at some point in future if that were ever required. It solves issue: exercism#3349 This is my first (ever) PR to an open source project, encouraged by Katrina's appearance on the Bike Shed podcast, but you won't hurt my feelings if there are things that are not correct.
This commit removes the internationalization element and simply copies the required text.
This commit removes the tooltips completely in favour of explaining what archiving does on the dashboard. I prefer this approach as while I expect most of Exercism's traffic to be desktop (keyboard and mouse) tooltips have very poor usability on touch screens such as tablets and mobiles. It solves issue:
kytrinyx
force-pushed
the
dictionary_with_first_entry_archive_tooltip
branch
from
736b9a1
to
757a29e
Compare
|
Thanks so much for working on this! ✨ Sorry it took so long to get it merged—things have been a bit hectic lately, and I apologize for letting that affect your first foray into open source contribution. 💜 💙 💛 |
|
No problem! Thanks for being so encouraging. I shall pick up a few more of the issues when I've got some more time. TB |
There is some confusion around what the archive functionality actually
does, and also some concern about maintaining consistency across
tooltip text.
This commit proposes making use of the i18n gem to provide a
dictionary as it ships with activesupport and will be intuitive to those
from a rails background. It would also support providing translations at
some point in future if that were ever required.
It solves issue:
#3349
This is my first (ever) PR to an open source project, encouraged by
Katrina's appearance on the Bike Shed podcast, but you won't hurt my
feelings if there are things that are not correct.