remove negative exit codes and other shellchecks in wedge_power.sh #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…acebook#228) Summary: Pull Request resolved: facebook#228 I was getting shellcheck errors when editing this file in another diff. Negative exit codes and return values are not supported in bash: https://unix.stackexchange.com/questions/418784/what-is-the-min-and-max-values-of-exit-codes-in-linux Test Plan: This is the only usage of it in code and it doesn't rely on a negative exit code (which couldn't happen anyways): https://www.internalfb.com/code/search?q=WEDGE_POWER_RESET_CMD Reviewed By: doranand Differential Revision: D47138227 fbshipit-source-id: 62c9cd1c68530738903f7c711a33a6b17c212bbb
|
This pull request was exported from Phabricator. Differential Revision: D47138227 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D47138227 |
Scott8440
force-pushed
the
export-D47138227
branch
from
3872cdc
to
7d0debc
Compare
|
This pull request has been merged in 0554af8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: I was getting shellcheck errors when editing this file in another diff. Negative exit codes and return values are not supported in bash: https://unix.stackexchange.com/questions/418784/what-is-the-min-and-max-values-of-exit-codes-in-linux
Test Plan: This is the only usage of it in code and it doesn't rely on a negative exit code (which couldn't happen anyways): https://www.internalfb.com/code/search?q=WEDGE_POWER_RESET_CMD
Differential Revision: D47138227
Reviewed By: smithscott