Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove negative exit codes and other shellchecks in wedge_power.sh #228

Closed
wants to merge 1 commit into from
Closed

remove negative exit codes and other shellchecks in wedge_power.sh #228

wants to merge 1 commit into from

Commits on Jun 29, 2023

  1. remove negative exit codes and other shellchecks in wedge_power.sh (f… 

    …acebook#228)

Summary:
Pull Request resolved: facebook#228

I was getting shellcheck errors when editing this file in another diff. Negative exit codes and return values are not supported in bash: https://unix.stackexchange.com/questions/418784/what-is-the-min-and-max-values-of-exit-codes-in-linux

Test Plan: This is the only usage of it in code and it doesn't rely on a negative exit code (which couldn't happen anyways): https://www.internalfb.com/code/search?q=WEDGE_POWER_RESET_CMD

Reviewed By: doranand

Differential Revision: D47138227

fbshipit-source-id: 62c9cd1c68530738903f7c711a33a6b17c212bbb
    @Scott8440 @facebook-github-bot
    Scott8440 authored and facebook-github-bot committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    7d0debc View commit details
    Browse the repository at this point in the history