Fixes old version comparison

femtopixel · Jun 7, 2019 · 9821e19 · 9821e19
1 parent 1f1159f
commit 9821e19
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/Makefile b/Makefile
@@ -1,4 +1,4 @@
-VERSION ?= 0.4.4
+VERSION ?= 0.4.5
 CACHE ?= --no-cache=1
 FULLVERSION ?= ${VERSION}
 archs ?= arm32v7 amd64 i386 arm64v8 arm32v6

diff --git a/github_release_notifier/__init__.py b/github_release_notifier/__init__.py
@@ -3,4 +3,4 @@
 """
 
 __all__ = ['parser', 'webhook', 'notifier']
-__version__ = '0.4.4'
+__version__ = '0.4.5'
diff --git a/github_release_notifier/notifier.py b/github_release_notifier/notifier.py
@@ -6,6 +6,7 @@
 import requests
 import logging
 import threading
+import re
 from .webhook import get, get_list
 from .parser import parse
 from pathlib import Path
@@ -38,10 +39,10 @@ def run(file: str = __DEFAULT_FILE__) -> dict:
             for entry in parse(package):
                 try:
                     condition = version_compare(str(entry['version']), str(get_version(package))) > 0
-                except e:
+                except TypeError:
                     try:
                         condition = LooseVersion(str(entry['version'])) > LooseVersion(str(get_version(package)))
-                    except e:
+                    except (AttributeError, TypeError):
                         condition = False
                 if condition:
                     database = _get_database(file)