New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dccnpath #2282
Update dccnpath #2282
Conversation
Update 07/07/2023
Update 11/07/2023
12/07/2023
…tically download files and folders to the local copy, if they are not already downloaded. To download a whole folder, dccnpath uses the function utilities/private/recursiveDownload.m, 2. test_dccnpath is created to test the old and the newly added functionality
…. when ft_default.dccnpath is not specified the data are automatically downloaded to the tempdir 2. dccnpath() always outputs a path, even for alternative1 3. warning for private data and automatic errors given by webread for typos in the path.
With the latest commit I added new features to Questions
Why are we using this chunk of code? If the contributor's current working directory in MATLAB is the one that the test data are downloaded, then why he should not be able to use alternative1 to find the right path?
|
…ataFolder did not exist. On the contrary, when I added a '/' in the end of the path, i.e., dccnpath(path/to/testdataFolder/) was not giving an error even if testdataFolder did not exist.
…ath outline given in ft_default.dccnpath. Based on this, test_dccnpath was updated accordingly
…sts with public data in my local laptop and I did minor changes to 3 of them to work correctly together with dccnpath
… into update_dccnpath
…not for users in the DCCN cluster
The Two issues I want to highlight:
|
This PR is associated with issue #2281.
However, in
dccnpath
still two things need to be done (see:Todo
notes in thedccnpath
script):% Todo: FTP connection of private data:
Download private data to the local copy from the DCCN cluster. This will apply only for employees and interns of the DCCN that have access to the DCCN intranet. I did not do that yet since I have no connection to the DCCN intranet. I will have connection after 1st of August.% Check if filename exists. If not, download it (Todo: after permission):
Ask the permission of the user prior to downloading the data.The
test_dccnpath
has been tested in Windows and it works. It should also be tested in Mac/Linux.The list of DEPENDENCIES in the
test_dccnpath
are not accurate. They should be checked again. One question is how we are going to label the DATA DEPENDENCY. For nowtest_dccnpath
only uses public data, but when% Todo: FTP connection of private data
is completed it should also work on private data. My suggestion% DATA public private
.Help documentation still needs to be updated based on issue #2281.
Lastly, in
dccnpath
something that needs more attention isif ~exist(alternative2, 'file')
. This checks if the file or folder exists. If not, it downloads them automatically. However, in the case of the folder it is important to check what files are missing from that folder and not generally if the folder is missing. Because if the folder exists but it is empty then nothing is downloaded while it should have.