Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build in fileio support for the MEF format #2394

Merged
merged 19 commits into from Mar 4, 2024
Merged

Conversation

schoffelen
Copy link
Contributor

This is a trimmed down version of the original PR by @jiecui: #2379

Copy link

You should test whether your modifications do not break anything.
See https://www.fieldtriptoolbox.org/development/testing/

When outside the DCCN, please consider testing: test_bug1571, test_bug2482, inspect_issue1216, test_tutorial_eventrelatedaveraging, test_yorkinstruments, test_bug1404, test_bug3075, test_bug2277, test_bug2231, test_bug2370, test_bug2956, test_issue1585, test_pull731, test_issue2021, test_ft_combineplanar, test_bug1408, test_bug97, test_tutorial_preprocessing, test_pull1331, test_bug804, test_bug1262, test_bug1397, test_pull2050, test_pull1600, test_example_incorporate_head_movements, test_tutorial_timefrequencyanalysis20130308, test_firwsfiltering, test_read_trigger, test_tutorial_meguk2015, test_issue1311, test_bug1248, test_bug2269, test_tutorial_eeg_preprocessing, test_bug1142, test_tutorial_timefrequencyanalysis, test_bug2590, test_issue627

When inside the DCCN, please also consider testing: test_bug2888, test_bug1571, test_bug1856, test_bug2482, test_pull574_reref, test_bug1125, test_bug1427, test_issue2026, inspect_issue1216, test_pull1271, test_bug2385, test_yorkinstruments, test_bug1407, test_bug182, test_ft_read_header, test_curry, test_bug629, test_bug1667, test_issue1972, test_bug2303, test_bug3207, test_readcompresseddata, test_bug2093, test_pull2111, test_bug1807, test_bug2231, test_ctf2grad, test_issue1425, test_issue1320, test_bug1914, test_issue1585, test_bug2060, test_pull731, test_bug2415, test_issue1992, test_bug1412, test_bug97, test_ft_preprocessing, test_bug1924, test_pull1229, test_bug1266, test_bug1490b, test_bug2220, test_bug2027, inspect_bug645, test_issue789, test_bug1808, test_bug963, test_pull832, test_bug1306, test_bug804, test_bug1262, test_bug1665, test_issue1991, test_bug1359, test_bug2170, test_bug2887, test_bug1490, test_bug1348, test_tutorial_meguk2015, test_bug1403, test_bug1998, test_bug1129, test_issue1387, test_pull769, test_issue1601, test_bug3027, test_pull1248

Suggested tests outside the DCCN use public data or do not use data.
Suggested tests inside the DCCN use private data.

@schoffelen
Copy link
Contributor Author

schoffelen commented Feb 22, 2024

Hi @jiecui, my suggestion would be to take it from here. I am currently trying (suffering) to get the Darkhorse stuff installed on our compute cluster, and combined with your toolbox, so that I can minimally test the functionality with your supplied test function. If that all works, I can proceed by making a scaffold page for the documentation, so that people can be instructed what to download (read_MED and your toolbox + setup the mex files) so that they can get started themselves.

Does that sound like a plan?

@jiecui
Copy link
Contributor

jiecui commented Feb 22, 2024

Hi @schoffelen, thank you so much for the effort! Sounds great! Please let me know if there is anything I can contribute. Just apologize in advance in case my response is slow. BTW, I think the link to download the latest version of "read_MED" from DHN (Darkhorse Neuro) is https://darkhorseneuro.com/downloads.html#utilities (then choose the download per OS).

Copy link

You should test whether your modifications do not break anything.
See https://www.fieldtriptoolbox.org/development/testing/

When outside the DCCN, please consider testing: test_bug3075, test_tutorial_eeg_preprocessing, test_bug1248, test_bug2231, test_bug2482, test_pull1331, test_bug1408, test_bug2956, test_pull1600, test_bug2277, test_bug1142, test_bug804, test_bug2370, test_bug1571, test_yorkinstruments, test_ft_combineplanar, test_issue1311, test_bug2590, test_bug1262, test_read_trigger, test_issue1585, test_pull731, test_tutorial_meguk2015, test_issue627, test_bug1404, test_tutorial_timefrequencyanalysis, test_bug97, test_pull2050, test_example_incorporate_head_movements, test_tutorial_preprocessing, test_tutorial_eventrelatedaveraging, test_tutorial_timefrequencyanalysis20130308, test_bug1397, inspect_issue1216, test_bug2269, test_issue2021, test_firwsfiltering

When inside the DCCN, please also consider testing: test_bug1914, test_bug2303, test_bug3207, test_pull2111, test_bug2093, test_issue2026, test_issue1425, test_ft_preprocessing, test_bug1266, test_bug1807, test_issue1992, test_bug2415, test_issue1320, test_bug2231, test_bug1490b, test_bug1665, test_bug2887, test_pull769, test_bug629, test_bug1856, test_bug2170, test_bug804, test_ft_read_header, test_issue789, test_bug1571, test_yorkinstruments, test_bug1407, test_issue1601, test_ctf2grad, test_bug1667, test_bug1306, test_issue1972, test_bug1262, test_bug1125, test_bug1924, test_issue1585, test_bug1998, test_bug1359, test_bug2220, test_bug1427, test_bug1129, test_pull731, test_tutorial_meguk2015, test_bug3027, test_bug1403, test_bug182, test_readcompresseddata, test_bug1490, test_issue1991, test_bug2027, test_bug97, test_bug2060, test_pull1229, test_bug2385, test_pull1271, test_pull832, test_pull1248, test_bug1348, test_curry, test_bug963, test_pull574_reref, test_bug1412, test_bug1808, inspect_bug645, test_issue1387, inspect_issue1216, test_bug2482, test_bug2888

Suggested tests outside the DCCN use public data or do not use data.
Suggested tests inside the DCCN use private data.

@schoffelen
Copy link
Contributor Author

I am almost there, but I cannot read the version 1 files, because the darkhorseneuro code has been compiled against a version of glibc that I don't have access to.

@schoffelen
Copy link
Contributor Author

do you know whether the source code for read_MED can be downloaded from somewhere?

@schoffelen
Copy link
Contributor Author

I tried to read MED 1 files on my Mac, but also failed.... My current conclusion is that the code provided by darkhorse is not really robust.

Copy link

github-actions bot commented Mar 4, 2024

You should test whether your modifications do not break anything.
See https://www.fieldtriptoolbox.org/development/testing/

When outside the DCCN, please consider testing: test_yorkinstruments, test_bug2370, test_bug2269, test_bug3075, test_bug2482, test_bug2956, test_bug804, test_pull1600, test_bug1248, test_firwsfiltering, test_pull731, test_issue1311, test_bug2277, test_tutorial_eventrelatedaveraging, test_bug1262, test_bug2590, test_bug97, test_tutorial_timefrequencyanalysis, test_tutorial_preprocessing, test_bug1397, test_tutorial_eeg_preprocessing, test_bug1571, test_bug1142, test_tutorial_timefrequencyanalysis20130308, test_ft_combineplanar, test_bug1408, test_pull2050, test_issue2021, test_example_incorporate_head_movements, test_issue1585, test_bug2231, test_read_trigger, test_bug1404, test_tutorial_meguk2015, test_issue627, test_pull1331, inspect_issue1216

When inside the DCCN, please also consider testing: test_bug2415, test_bug1359, test_yorkinstruments, inspect_bug645, test_bug1490, test_bug1808, test_issue789, test_pull1248, test_bug1665, test_bug2482, test_bug3027, test_issue1425, test_bug804, test_bug1856, test_pull2111, test_bug963, test_bug1490b, test_bug1667, test_bug1266, test_bug1427, test_bug1807, test_bug1403, test_pull731, test_bug182, test_issue1991, test_bug2060, test_bug2888, test_issue2026, test_issue1320, test_pull832, test_bug2220, test_bug1262, test_bug629, test_bug1412, test_bug97, test_bug2093, test_ft_read_header, test_issue1972, test_bug2027, test_bug1571, test_pull1229, test_bug1306, test_bug1125, test_bug1998, test_issue1585, test_curry, test_bug1407, test_bug2385, test_issue1387, test_bug2231, test_issue1601, test_bug1924, test_bug1914, test_bug2887, test_pull574_reref, test_bug1348, test_tutorial_meguk2015, test_ft_preprocessing, test_bug1129, test_pull1271, test_issue1992, test_readcompresseddata, test_ctf2grad, test_bug2303, test_bug2170, test_pull769, test_bug3207, inspect_issue1216

Suggested tests outside the DCCN use public data or do not use data.
Suggested tests inside the DCCN use private data.

Copy link

github-actions bot commented Mar 4, 2024

You should test whether your modifications do not break anything.
See https://www.fieldtriptoolbox.org/development/testing/

When outside the DCCN, please consider testing: test_tutorial_preprocessing, test_bug3075, test_tutorial_eeg_preprocessing, test_example_incorporate_head_movements, test_issue1311, test_read_trigger, test_bug2956, test_bug2231, test_tutorial_meguk2015, test_bug1397, test_bug1142, test_bug2590, test_issue1585, test_pull2050, test_firwsfiltering, test_ft_combineplanar, test_issue2021, test_tutorial_timefrequencyanalysis, test_tutorial_timefrequencyanalysis20130308, test_bug1408, test_bug1262, test_bug1571, test_tutorial_eventrelatedaveraging, test_bug2277, test_pull1600, inspect_issue1216, test_bug97, test_bug2269, test_issue627, test_bug1248, test_yorkinstruments, test_bug2370, test_pull731, test_bug804, test_bug2482, test_bug1404, test_pull1331

When inside the DCCN, please also consider testing: test_pull832, test_bug2482, test_pull2111, test_bug1266, test_curry, test_bug1359, test_pull1229, test_pull1271, test_bug2385, test_bug1924, test_bug2170, test_bug2231, test_bug1125, test_bug3027, test_pull769, test_bug1808, test_tutorial_meguk2015, test_bug2060, test_bug1306, test_pull1248, test_readcompresseddata, test_bug1856, test_bug629, test_bug182, test_bug1807, test_ft_read_header, test_issue1992, test_bug2093, test_bug2027, test_issue1585, test_bug1665, inspect_bug645, test_bug1427, test_bug1998, test_bug1490, test_bug1403, test_bug1348, test_bug1490b, test_bug1667, test_ft_preprocessing, test_bug1407, test_bug2220, test_bug1412, test_bug3207, test_bug1262, test_issue1320, test_bug2415, test_pull574_reref, test_issue1387, test_issue789, test_bug1914, test_bug1571, test_bug2887, test_issue2026, test_bug963, test_bug2303, inspect_issue1216, test_bug97, test_bug1129, test_issue1991, test_yorkinstruments, test_bug2888, test_issue1972, test_pull731, test_bug804, test_issue1601, test_issue1425, test_ctf2grad

Suggested tests outside the DCCN use public data or do not use data.
Suggested tests inside the DCCN use private data.

@schoffelen
Copy link
Contributor Author

I would like to move forward with this. At this stage I think that - as far as this PR is concerned - nothing needs to be done anymore. The following PRs still need work though: fieldtrip/website#771, and
jiecui/mef_reader_fieldtrip#1

@jiecui I will merge this PR here for now, and hope that you will find some time soon to work on the other PRs

@schoffelen schoffelen merged commit be34a25 into fieldtrip:master Mar 4, 2024
2 checks passed
@schoffelen schoffelen deleted the mef branch March 4, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants