Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix snapshotting example build #540

Closed

Conversation

pnasrat
Copy link

@pnasrat pnasrat commented Mar 27, 2024

Description of changes:

Updates go mod for 1.21, tc-redirect-tap, and cni plugins

Removes deleted dependency github.com/mitchellh/osext

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

With out this build fails:

$ make
go build -o snapshot-example
mkdir -p bin
GOBIN=/home/pnasrat/workspace/src/github.com/firecracker-microvm/firecracker-go-sdk/examples/cmd/snapshotting/bin go install github.com/awslabs/tc-redirect-tap/cmd/tc-redirect-tap@v0.0.0-20220715050423-f2af44521093
go: github.com/awslabs/tc-redirect-tap/cmd/tc-redirect-tap@v0.0.0-20220715050423-f2af44521093: version constraints conflict:
	github.com/awslabs/tc-redirect-tap@v0.0.0-20220715050423-f2af44521093 indirectly requires github.com/mitchellh/osext@v0.0.0-20151018003038-5e2d6d41470f: github.com/mitchellh/osext@v0.0.0-20151018003038-5e2d6d41470f: invalid version: git ls-remote -q origin in /home/pnasrat/go/pkg/mod/cache/vcs/94ed57c5b21c953d93b47487113db43a5c9b69fd990329ec70dc77348c4dd443: exit status 128:
	fatal: could not read Username for 'https://github.com': terminal prompts disabled
Confirm the import path was entered correctly.
If this is a private repository, see https://golang.org/doc/faq#git_https for additional information.
make: *** [Makefile:47: bin/tc-redirect-tap] Error 1

@pnasrat pnasrat requested a review from a team as a code owner March 27, 2024 13:04
Updates go mod for 1.21, tc-redirect-tap, and cni plugins

Removes deleted dependency github.com/mitchellh/osext

Signed-off-by: Pris Nasrat <pnasrat@gmail.com>
@swagatbora90
Copy link
Contributor

@pnasrat Thanks for your contribution. Please rebase the PR.

@@ -1,6 +1,6 @@
module main

go 1.18
go 1.21
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SDK currently does not define a policy for go version support. Our main intention has been to not break support for those SDK users who are on the LTS version of some of the popular linux distros such as Debian 11, Ubuntu 22.04 LTS. That is the reason why we have kept support for older versions of go. However we have realized that in some cases it becomes necessary to update the go version since newer dependency version no longer support old versions of go (or we end up pinning the version which is less favorable). See #364

@pnasrat
Copy link
Author

pnasrat commented Apr 12, 2024

This was handled in the merge #546 which updates to 1.18 and also ran go mod tidy

@pnasrat pnasrat closed this Apr 12, 2024
@pnasrat pnasrat deleted the fix-snapshotting-example branch April 12, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants