Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix snapshotting example build #540

Closed
wants to merge 1 commit into from
Closed

Fix snapshotting example build #540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion examples/cmd/snapshotting/.gitignore
View file
Open in desktop
@@ -1,2 +1,4 @@
bin/

root-drive-*
root-drive-with-ssh.img
snapshot-example
6 changes: 3 additions & 3 deletions examples/cmd/snapshotting/Makefile
View file
Open in desktop
Expand Up @@ -44,13 +44,13 @@ bin:
mkdir -p bin

bin/tc-redirect-tap: bin
$(call install_go,github.com/awslabs/tc-redirect-tap/cmd/tc-redirect-tap,v0.0.0-20220715050423-f2af44521093)
$(call install_go,github.com/awslabs/tc-redirect-tap/cmd/tc-redirect-tap,v0.0.0-20240321155514-f4bce16532c3)

bin/ptp: bin
$(call install_go,github.com/containernetworking/plugins/plugins/main/ptp,v1.1.1)
$(call install_go,github.com/containernetworking/plugins/plugins/main/ptp,v1.4.1)

bin/host-local: bin
$(call install_go,github.com/containernetworking/plugins/plugins/ipam/host-local,v1.1.1)
$(call install_go,github.com/containernetworking/plugins/plugins/ipam/host-local,v1.4.1)

vmlinux:
$(curl) -o vmlinux https://s3.amazonaws.com/spec.ccfc.min/img/quickstart_guide/${ARCH}/kernels/vmlinux.bin
Expand Down
6 changes: 3 additions & 3 deletions examples/cmd/snapshotting/go.mod
View file
Open in desktop
@@ -1,6 +1,6 @@
module main

go 1.18
go 1.21
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SDK currently does not define a policy for go version support. Our main intention has been to not break support for those SDK users who are on the LTS version of some of the popular linux distros such as Debian 11, Ubuntu 22.04 LTS. That is the reason why we have kept support for older versions of go. However we have realized that in some cases it becomes necessary to update the go version since newer dependency version no longer support old versions of go (or we end up pinning the version which is less favorable). See #364


require (
github.com/firecracker-microvm/firecracker-go-sdk v1.0.0
Expand All @@ -11,8 +11,8 @@ require (
require (
github.com/asaskevich/govalidator v0.0.0-20210307081110-f21760c49a8d // indirect
github.com/containerd/fifo v1.0.0 // indirect
github.com/containernetworking/cni v1.1.2 // indirect
github.com/containernetworking/plugins v1.1.1 // indirect
github.com/containernetworking/cni v1.4.1 // indirect
github.com/containernetworking/plugins v1.4.1 // indirect
github.com/go-openapi/analysis v0.21.4 // indirect
github.com/go-openapi/errors v0.20.3 // indirect
github.com/go-openapi/jsonpointer v0.19.5 // indirect
Expand Down