Add support for country_select v9. Fixes #1381 #1382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `country_select` v2 syntax was introduced in [August 2014](https://github.com/countries/country_select/blob/19072737cc2b2a12723b2dd273263b71fd5395ed/UPGRADING.md). Now, 10 years and 7 major versions later, the project [dropped support for v1 syntax](countries/country_select#224) starting with v9. This change adapts `formtastic` to the new method signature, removes all claims that it supports v1 syntax, and updates the URLs to the new home under a new maintainer.
|
Looks great! 🙂 |
|
I think this is waiting on #1372. Let me know when anything needs to be amended. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
country_selectv2 syntax was introduced in August 2014.Now, 10 years and 7 major versions later, the project dropped support for v1 syntax starting with v9.
This change adapts
formtasticto the new method signature, removes all claims that it supports v1 syntax, and updates the URLs to the new home under a new maintainer.