drm-kmod: package description: correct and update #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct a typo (given, not give). Whilst here: aim to make the description more understandable to readers who may be new to, or relatively unfamiliar, with things such as DRM. In particular: * make clearer that modules are in a separate port (not this metaport).
grahamperrin
commented
Dec 11, 2022
grahamperrin
commented
Dec 11, 2022
| amd64, i915 and radeonkms DRM modules from the former base DRM component on | ||
| other architectures. | ||
| Metaport for different versions of Linux DRM based on the FreeBSD version | ||
| in use. This port encompasses the recommendations of the FreeBSDDesktop team |
There was a problem hiding this comment.
I guess, FreeBSDDesktop (one word) relates partly to:
Whilst I might have rephrased part of this line as recommendations of the FreeBSD Desktop team, it seems simpler to focus on describing what is recommended.
(If the reader is curious about who makes the recommendations, it should be easy enough to find https://github.com/freebsd/drm-kmod via the home icon at https://www.freshports.org/graphics/drm-kmod/, and so on.)
grahamperrin
commented
Dec 11, 2022
| @@ -1,11 +1,13 @@ | |||
| amdgpu, i915, and radeon DRM modules for the linuxkpi-based KMS components on | |||
| amd64, i915 and radeonkms DRM modules from the former base DRM component on | |||
There was a problem hiding this comment.
… modules for components on modules from … was difficult to understand.
I wondered whether components on should have been components based on.
grahamperrin
commented
Dec 11, 2022
graphics/drm-kmod/pkg-descr
Outdated
| DRM. | ||
| This port does not however hinder the expert user to make other decisions and | ||
| continue to install DRM ports directly. | ||
| Direct Rendering Manager (DRM) modules for LinuxKPI-based kernel mode setting |
There was a problem hiding this comment.
Mixed case Kernel Mode Setting, and variants such as Kernel Modesetting, Kernel Mode-Setting and Kernel-based Mode Setting, are possible.
I chose lowercase for kernel mode setting, it seems tidy (least distracting).
Comment <https://reviews.freebsd.org/D37672#inline-231321>: done.
Comment <https://reviews.freebsd.org/D37672#inline-231313>: done. If it's useful to know what was in parentheses: <https://github.com/freebsd/drm-kmod/blob/master/README.md> can make an explanation.
If a person has the expertise to take an 'expert approach': I doubt that the person will need (in a package message) the bullet point about hindrance.
freebsd-git
pushed a commit
that referenced
this pull request
Feb 26, 2023
ChangeLog: Core Using vlucas/valitron for user input validation Bumped FontAwesome to version 6.2.0 (#141) PHP versions 7.4 is now the minimal supported versions, older versions are not supported anymore (#143) extended support for PHP 8.1 (#147) Separated some templates into application/views/templates/partials folder (#144) Removed Composer lock file from git repository To avoid any potential issues for users using different version of PHP, composer.lock has been removed from the Git repo Fixed how MVC is implemented by using psr-15 http-handler (#145) Added router and user authentication middlewares Using single pass psr-15 middleware for application routing and user authentication Disabling user authentication does not display a blank page anymore (#140) Improved how exceptions and errors are handled (#145) PHP errors and exception handler and renderer has been refactored (#148) Instantiate Session instance from the Core Controller (#149) Disabling users authentication does not create a fatalog error nor blank page anymore (#135) Dashboard Breadcrumb navigation is now hidden on home page (Dashboard) Jobs report Fixed error with elapsed time when a job haven't been started yet if a job is in pending status, elapsed time column will display 'n/a' Docker image Provided Docker image on Docker Hub (#153) Documentation Update documentation about deprecated version and general security information (#142) Updated / fixed documentation The FAQ has been fixed / updated Security Added security policy and documented know security vulnerabilities (#135 and #140) Fixed New feature(s) Thanks to @sruckh, @skidoo23 and all community users for their feedback, tests, help and bug reports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct a typo (given, not give).
Whilst here: aim to make the description more understandable to readers who may be new to, or relatively unfamiliar, with things such as DRM. In particular: