Change PAGES context variable to pages in all themes

[jerryasher]

Who "owns" the various themes? Referring to Remove PAGES; use pages instead #1767, it seems as though many (most) themes will break in 3.7.0.

Who "owns" the various themes in pelican-themes?
Would it be wrong to globally change all templates referencing PAGES?
I sense it would be, but what will the process be for updating the themes and when would it take place?

Are you interested in pull requests to fix one theme at a time? For instance, I am using zurb-F5-basic, would you like the changes to the base.html and index.html?

FWIW, I see:

$ find . -name \*html | xargs grep "in PAGES"
./aboutwilson/templates/base.html:                          {% for page in PAGES %}
./bootlex/templates/base.html:              {% for p in PAGES %}
./bootstrap/templates/base.html:                    {% for page in PAGES %}
./bootstrap2/templates/base.html:              {% for page in PAGES %}
./bootstrap2/templates/index.html:                {% for page in PAGES %}
./bootstrap2-dark/templates/base.html:              {% for page in PAGES %}
./bootstrap2-dark/templates/index.html:                {% for page in PAGES %}
./brownstone/templates/base.html:                                                        {% for page in PAGES %}
./built-texts/templates/base.html:          {% for page in PAGES %}
./cebong/templates/base.html:                {% for page in PAGES %}
./cebong/templates/index.html:    {% for page in PAGES %}
./dev-random/templates/includes/sidebar.html:          {% for p in PAGES %}
./dev-random2/templates/includes/sidebar.html:              {% for p in PAGES %}
./foundation-default-colours/templates/base.html:                             {% for pg in PAGES | sort(attribute='index') %}                                                                                                          
</div>
./gum/templates/base.html:              {% for p in PAGES %}
./gum/templates/sidebar.html:    {% for p in PAGES %}
./Just-Read/templates/base.html:        {% for p in PAGES %}
./lightweight/templates/menu.html:    {% for p in PAGES %}
./mnmlist/templates/base.html:                {% for page in PAGES %}
./monospace/templates/base.html:                {% for page in PAGES %}
./new-bootstrap2/templates/base.html:              {% for gpage in PAGES %}
./new-bootstrap2/templates/index.html:        {% for page in PAGES %}
./nmnlist/templates/base.html:                {% for page in PAGES %}
./notebook/templates/base.html:      {% for p in PAGES %}
./notmyidea-cms/templates/base.html:                {% for p in PAGES %}
./notmyidea-cms/templates/index.html:{% for page in PAGES %}
./notmyidea-cms-fr/templates/base.html:                {% for p in PAGES %}
./notmyidea-cms-fr/templates/index.html:{% for page in PAGES %}
./photowall/templates/base.html:                {% for pg in PAGES %}
./photowall/templates/index.html:    {% for page in PAGES %}
./simple-bootstrap/templates/base.html:                {% for p in PAGES %}
./sneakyidea/templates/base.html:                    {% for current_page in PAGES %}
./sneakyidea/templates/index.html:{% for page in PAGES %}
./SoMA/templates/index.html:        {% for page in PAGES %}
./SoMA2/templates/index.html:        {% for page in PAGES %}
./subtle/templates/base.html:                {% for page in PAGES %}
./subtle/templates/index.html:    {% for page in PAGES %}
./syte/templates/base.html:        {% for current_page in PAGES %}
./tuxlite_tbs/templates/base.html:        {% for page in PAGES %}
./tuxlite_zf/templates/base.html:        {% for page in PAGES %}
./tuxlite_zf/templates/index.html:    {% for page in PAGES %}
./waterspill/templates/base.html:        {% for page in PAGES %}
./waterspill-en/templates/base.html:            {% for page in PAGES %}
./zurb-F5-basic/templates/base.html:        {% for page in PAGES %}
./zurb-F5-basic/templates/index.html:    {% for page in PAGES %}
Dell15:~/d/workspace/upstream.pelican/pelican-themes (pages)
$ 

[justinmayer]

Hey Jerry. Thanks for creating an issue to track this effort. Pelican 3.7 has been released, so now would indeed be a good time to effect this change. I think that a single pull request that updates all the themes in the repo would be just fine. Is that something you could help out with? (^_^)

[jerryasher]

Hey! Congratulations on releasing Pelican 3.7! Yes, I can do this, but not in the next few immediate days. If you would like this earlier than a week or so from now, I should probably step back. Jerry

…

On Mon, Dec 12, 2016 at 3:40 PM, Justin Mayer ***@***.***> wrote: Hey Jerry. Thanks for creating an issue to track this effort. Pelican 3.7 has been released, so now would indeed be a good time to effect this change. I think that a single pull request that updates all the themes in the repo would be just fine. Is that something you could help out with? (^_^) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#437 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAosCfjYXxMA4S0p6EHunCWJmca-_27Xks5rHdtxgaJpZM4KL5mQ> .

[jerryasher]

Hi Justin, I can't believe it's been a month since you asked. I honestly thought, oh man that was two weeks ago, I need to get back to this... Would you still like help with this issue? On the one hand, it seems a simple change, and it's difficult for me to think I could screw it up. But I probably could... Which makes me wonder, how are themes in the repository tested? At any rate, I have done the following: 1. Updated my local pelican themes repository with 1. git fetch origin 2. git checkout master 3. pull 2. find . -type f | xargs grep PAGES > pages.txt I opened up the file pages.txt and removed all occurrences of 1. BANNER_ALL_PAGES 2. DISPLAY_PAGES_ON_MENU 3. PAGES_SORT_ATTRIBUTE Then deleted all lines that did not contain PAGES on it. There appear to be 52 occurrences of PAGES in pelican in 46 files. You can find them here: https://gist.github.com/jerryasher/d6936d08eec5135fbb0aa8fd4b31dc5c Does this seem reasonable or am I missing something. I'm still a git n00b, so if I fork pelican, change to a new branch, make these changes, and create a pull request, ... will that address occurrences within submodules? Is there anything else I would need to do? And I guess, ... how would I go about testing this? Thanks, Jerry

…

On Mon, Dec 12, 2016 at 3:49 PM, Jerry Asher ***@***.***> wrote: Hey! Congratulations on releasing Pelican 3.7! Yes, I can do this, but not in the next few immediate days. If you would like this earlier than a week or so from now, I should probably step back. Jerry On Mon, Dec 12, 2016 at 3:40 PM, Justin Mayer ***@***.***> wrote: > Hey Jerry. Thanks for creating an issue to track this effort. Pelican 3.7 > has been released, so now would indeed be a good time to effect this > change. I think that a single pull request that updates all the themes in > the repo would be just fine. Is that something you could help out with? > (^_^) > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#437 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AAosCfjYXxMA4S0p6EHunCWJmca-_27Xks5rHdtxgaJpZM4KL5mQ> > . >

[jerryasher]

Ah... Well, I now see I didn't go through the submodules...

So I have now recursively checked out the submodules,
git clone --recursive git@github.com:getpelican/pelican-themes.git

and redid the above, to find 115 occurrences in 99 files.

You can find those here:
https://gist.github.com/jerryasher/b439f5e8075c9eef344881ac3dde3ceb