Replace 'PAGES' with 'pages' across all themes

[adamatan]

The problem

Pelican now uses pages instead of PAGES in the HTML Jinja templates. However, not all themes have updated the code in their HTML files, which caused this common problem -

Since I upgraded Pelican my pages are no longer rendered

Which was reported as issue #437.

My solution

Regex substitution across all themes.

Code

I've used the following Python code to replace the occurrences in all HTML files. It's not intended to be efficient or beautiful, but please let me know if you spot any bugs or shortcomings.

#!/usr/bin/python

import os
import re

regex = '(.*%.*)([^A-Za-z_])(PAGES)([^A-Za-z_])(.*%.*)'
repl = '\g<1>\g<2>pages\g<4>\g<5>'

i = 0
for cur_dir, sub_dirs, filenames in os.walk('.'):
    html_filenames = [filename for filename in filenames if re.match('.*html$', filename)]
    if html_filenames:
        for filename in html_filenames:
            path = cur_dir + os.sep + filename
            with open(path) as rf:
                content = rf.read()

            matches = re.findall(regex, content)
            if matches:
                print(path)
                for match in matches:
                    i += 1
                    print("\t {:3d}  {}".format(i, ''.join(match).strip()))
                with open(path, 'wt') as wf:
                    wf.write(re.sub(regex, repl, content))

[almet]

Hi, thanks for taking the time to open an issue and for pinging us on twitter.

The changes looks fine to me, so let's merge these!

Please, note that the best way to reach the development team is via IRC, as outlined in the README of the project. I'm taking the liberty to merge here but I'm actually not the maintainer of pelican anymore.